User Details
User Details
- User Since
- Mar 19 2018, 1:18 AM (217 w, 6 d)
Mar 5 2021
Mar 5 2021
Looks good except for the typo.
Mar 5 2021, 10:05 AM · Restricted Project
ondrasej added inline comments to D97504: [llvm-exegesis] Disable the LBR check on AMD.
Mar 5 2021, 9:48 AM · Restricted Project
Mar 4 2021
Mar 4 2021
ondrasej requested changes to D97504: [llvm-exegesis] Disable the LBR check on AMD.
Mar 4 2021, 10:38 AM · Restricted Project
Mar 4 2021, 8:42 AM · Restricted Project
One more const-comment, otherwise looks good.
Mar 4 2021, 4:31 AM · Restricted Project
Mar 3 2021
Mar 3 2021
ondrasej added inline comments to D97504: [llvm-exegesis] Disable the LBR check on AMD.
Mar 3 2021, 3:45 AM · Restricted Project
Feb 26 2021
Feb 26 2021
ondrasej added inline comments to D97504: [llvm-exegesis] Disable the LBR check on AMD.
Feb 26 2021, 3:54 AM · Restricted Project
Oct 1 2020
Oct 1 2020
ondrasej added a comment to D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Oct 1 2020, 4:48 AM · Restricted Project
Sep 30 2020
Sep 30 2020
ondrasej accepted D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Thanks Vy!
Sep 30 2020, 9:20 AM · Restricted Project
Sep 16 2020
Sep 16 2020
ondrasej added inline comments to D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Sep 16 2020, 1:13 PM · Restricted Project
Aug 28 2020
Aug 28 2020
ondrasej added inline comments to D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Aug 28 2020, 3:45 AM · Restricted Project
Aug 7 2020
Aug 7 2020
ondrasej added a comment to D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Thanks Vy for working on this!
Aug 7 2020, 6:44 AM · Restricted Project
Jul 24 2020
Jul 24 2020
ondrasej added inline comments to D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..
Jul 24 2020, 9:10 AM · Restricted Project
Jul 23 2020
Jul 23 2020
ondrasej added inline comments to D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old..
Jul 23 2020, 11:36 PM · Restricted Project
Jul 8 2020
Jul 8 2020
ondrasej added a comment to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Looks good overall.
Jul 8 2020, 1:17 PM · Restricted Project
Jun 18 2020
Jun 18 2020
ondrasej added a comment to D81050: [llvm-exegesis] Let Counter returns up to 16 entries..
One last comment, but otherwise this looks good. I'll leave the approval to Clement.
Jun 18 2020, 12:34 PM · Restricted Project
Jun 11 2020
Jun 11 2020
ondrasej added a comment to D81050: [llvm-exegesis] Let Counter returns up to 16 entries..
I've added a couple of style comment + one bigger comment on the aggregation of results from multiple runs/counter buffer.
Jun 11 2020, 9:19 AM · Restricted Project
Jun 4 2020
Jun 4 2020
ondrasej added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Jun 4 2020, 3:45 AM · Restricted Project
Jun 3 2020
Jun 3 2020
ondrasej added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Jun 3 2020, 10:25 AM · Restricted Project
ondrasej added a comment to D81050: [llvm-exegesis] Let Counter returns up to 16 entries..
This looks good in general, but we should be careful about aggregating the values from the measurements (and aggregation when the counter returns multiple values). In particular for the LBR, we'd be losing interesting and potentially useful information by aggregating all the values into a single number.
Jun 3 2020, 1:36 AM · Restricted Project
Apr 9 2020
Apr 9 2020
ondrasej added inline comments to D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements..
Apr 9 2020, 7:34 AM · Restricted Project