This is an archive of the discontinued LLVM Phabricator instance.

[mlir] don't hardcode PDL_Operation in Transform dialect extensions
ClosedPublic

Authored by ftynse on May 17 2023, 7:28 AM.

Details

Summary

Update operations in Transform dialect extensions defined in the Affine,
GPU, MemRef and Tensor dialects to use the more generic
TransformHandleTypeInterface type constraint instead of hardcoding
PDL_Operation. See
https://discourse.llvm.org/t/rfc-type-system-for-the-transform-dialect/65702
for motivation.

Remove the dependency on PDLDialect from these extensions.

Update tests to use !transform.any_op instead of !pdl.operation.

Diff Detail

Event Timeline

ftynse created this revision.May 17 2023, 7:28 AM
ftynse requested review of this revision.May 17 2023, 7:28 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
ftynse updated this revision to Diff 523050.May 17 2023, 7:39 AM

Also do Bufferization dialect

nicolasvasilache accepted this revision.May 17 2023, 7:47 AM
This revision is now accepted and ready to land.May 17 2023, 7:47 AM