Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D150404

[OpenMP] remove an erroneous assert on the location argument
ClosedPublic
Actions

Authored by vadikp-intel on May 11 2023, 3:30 PM.

Details

Reviewers
jdoerfert
tianshilei1992
Summary

The 'loc' argument is optional, and some compilers (e.g. MSVC) do no supply it.

Diff Detail

Event Timeline

vadikp-intel created this revision.May 11 2023, 3:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 11 2023, 3:30 PM
Herald added subscribers: sunshaoce, guansong, yaxunl. · View Herald Transcript
vadikp-intel requested review of this revision.May 11 2023, 3:30 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptMay 11 2023, 3:30 PM
Herald added subscribers: openmp-commits, jplehr, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B231464: Diff 521473.May 11 2023, 3:34 PM
tianshilei1992 accepted this revision.May 11 2023, 10:21 PM
tianshilei1992 added a subscriber: tianshilei1992.

LG

This revision is now accepted and ready to land.May 11 2023, 10:21 PM
vadikp-intel closed this revision.May 12 2023, 3:43 PM

closed by commit 7fd6d2babf4dcaa24f24da18cd0a858fa89579e8

Revision Contents
Changeset List

PathSize
openmp/
runtime/
src/
1 line

Diff 521473

View Options

openmp/runtime/src/kmp_runtime.cpp

Loading...