This is an archive of the discontinued LLVM Phabricator instance.

Differential D149985

AMDGPU: Factor out GFX9.4 common features into a feature set
ClosedPublic

Authored by kzhuravl on May 5 2023, 12:44 PM.

Details

Reviewers
arsenm
msearles
rampitec
t-tye
Group Reviewers
Restricted Project
Commits
rGfae9e7d46ce5: AMDGPU: Factor out GFX9.4 common features into a feature set

Diff Detail

Event Timeline

kzhuravl created this revision.May 5 2023, 12:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 12:44 PM
Herald added subscribers: kosarev, foad, kerbowa and 5 others. · View Herald Transcript
kzhuravl requested review of this revision.May 5 2023, 12:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 12:44 PM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
Harbormaster completed remote builds in B230309: Diff 519952.May 5 2023, 12:44 PM
kzhuravl added parent revisions: D149982: AMDGPU: Add basic gfx941 target, D149983: AMDGPU: Add basic gfx942 target.May 5 2023, 12:45 PM
kzhuravl added a child revision: D149986: AMDGPU: Force sc0 and sc1 on stores for gfx940 and gfx941.
kzhuravl added a reviewer: Restricted Project.May 5 2023, 12:48 PM
arsenm accepted this revision.May 9 2023, 4:38 AM
This revision is now accepted and ready to land.May 9 2023, 4:38 AM
This revision was landed with ongoing or failed builds.May 10 2023, 8:46 AM
Closed by commit rGfae9e7d46ce5: AMDGPU: Factor out GFX9.4 common features into a feature set (authored by kzhuravl). · Explain Why
This revision was automatically updated to reflect the committed changes.
kzhuravl added a commit: rGfae9e7d46ce5: AMDGPU: Factor out GFX9.4 common features into a feature set.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
74 lines

Diff 519952

llvm/lib/Target/AMDGPU/AMDGPU.td

Show First 20 Lines • Show All 1,187 Lines • ▼ Show 20 Linesdef FeatureISAVersion9_0_C : FeatureSet<
FeatureMadMixInsts, FeatureMadMixInsts,
FeatureLDSBankCount32, FeatureLDSBankCount32,
FeatureDsSrc2Insts, FeatureDsSrc2Insts,
FeatureExtendedImageInsts, FeatureExtendedImageInsts,
FeatureImageInsts, FeatureImageInsts,
FeatureMadMacF32Insts, FeatureMadMacF32Insts,
FeatureImageGather4D16Bug]>; FeatureImageGather4D16Bug]>;
def FeatureISAVersion9_4_0 : FeatureSet< def FeatureISAVersion9_4_Common : FeatureSet<
[FeatureGFX9, [FeatureGFX9,
FeatureGFX90AInsts, FeatureGFX90AInsts,
FeatureGFX940Insts, FeatureGFX940Insts,
FeatureFmaMixInsts, FeatureFmaMixInsts,
FeatureLDSBankCount32, FeatureLDSBankCount32,
FeatureDLInsts, FeatureDLInsts,
FeatureFmacF64Inst, FeatureFmacF64Inst,
FeatureDot1Insts, FeatureDot1Insts,
Show All 17 Linesdef FeatureISAVersion9_4_Common : FeatureSet<
FeatureAtomicGlobalPkAddBF16Inst, FeatureAtomicGlobalPkAddBF16Inst,
FeatureFlatAtomicFaddF32Inst, FeatureFlatAtomicFaddF32Inst,
FeatureSupportsSRAMECC, FeatureSupportsSRAMECC,
FeaturePackedTID, FeaturePackedTID,
FeatureArchitectedFlatScratch, FeatureArchitectedFlatScratch,
FullRate64Ops, FullRate64Ops,
FeatureBackOffBarrier]>; FeatureBackOffBarrier]>;
def FeatureISAVersion9_4_0 : FeatureSet<
!listconcat(FeatureISAVersion9_4_Common.Features,
[])>;
def FeatureISAVersion9_4_1 : FeatureSet< def FeatureISAVersion9_4_1 : FeatureSet<
[FeatureGFX9, !listconcat(FeatureISAVersion9_4_Common.Features,
FeatureGFX90AInsts, [])>;
FeatureGFX940Insts,
FeatureFmaMixInsts,
FeatureLDSBankCount32,
FeatureDLInsts,
FeatureFmacF64Inst,
FeatureDot1Insts,
FeatureDot2Insts,
FeatureDot3Insts,
FeatureDot4Insts,
FeatureDot5Insts,
FeatureDot6Insts,
FeatureDot7Insts,
FeatureDot10Insts,
FeatureAtomicDsPkAdd16Insts,
FeatureAtomicFlatPkAdd16Insts,
Feature64BitDPP,
FeaturePackedFP32Ops,
FeatureMAIInsts,
FeatureFP8Insts,
FeaturePkFmacF16Inst,
FeatureAtomicFaddRtnInsts,
FeatureAtomicFaddNoRtnInsts,
FeatureAtomicBufferGlobalPkAddF16Insts,
FeatureAtomicGlobalPkAddBF16Inst,
FeatureFlatAtomicFaddF32Inst,
FeatureSupportsSRAMECC,
FeaturePackedTID,
FeatureArchitectedFlatScratch,
FullRate64Ops,
FeatureBackOffBarrier]>;
def FeatureISAVersion9_4_2 : FeatureSet< def FeatureISAVersion9_4_2 : FeatureSet<
[FeatureGFX9, !listconcat(FeatureISAVersion9_4_Common.Features,
FeatureGFX90AInsts, [])>;
FeatureGFX940Insts,
FeatureFmaMixInsts,
FeatureLDSBankCount32,
FeatureDLInsts,
FeatureFmacF64Inst,
FeatureDot1Insts,
FeatureDot2Insts,
FeatureDot3Insts,
FeatureDot4Insts,
FeatureDot5Insts,
FeatureDot6Insts,
FeatureDot7Insts,
FeatureDot10Insts,
FeatureAtomicDsPkAdd16Insts,
FeatureAtomicFlatPkAdd16Insts,
Feature64BitDPP,
FeaturePackedFP32Ops,
FeatureMAIInsts,
FeatureFP8Insts,
FeaturePkFmacF16Inst,
FeatureAtomicFaddRtnInsts,
FeatureAtomicFaddNoRtnInsts,
FeatureAtomicBufferGlobalPkAddF16Insts,
FeatureAtomicGlobalPkAddBF16Inst,
FeatureFlatAtomicFaddF32Inst,
FeatureSupportsSRAMECC,
FeaturePackedTID,
FeatureArchitectedFlatScratch,
FullRate64Ops,
FeatureBackOffBarrier]>;
// TODO: Organize more features into groups. // TODO: Organize more features into groups.
def FeatureGroup { def FeatureGroup {
// Bugs present on gfx10.1. // Bugs present on gfx10.1.
list<SubtargetFeature> GFX10_1_Bugs = [ list<SubtargetFeature> GFX10_1_Bugs = [
FeatureVcmpxPermlaneHazard, FeatureVcmpxPermlaneHazard,
FeatureVMEMtoScalarWriteHazard, FeatureVMEMtoScalarWriteHazard,
FeatureSMEMtoVectorWriteHazard, FeatureSMEMtoVectorWriteHazard,
▲ Show 20 Lines • Show All 654 Lines • Show Last 20 Lines