This is an archive of the discontinued LLVM Phabricator instance.

Differential D149971

[UpdateTestChecks] More support for X86 exception handling
ClosedPublic

Authored by foad on May 5 2023, 9:19 AM.

Details

Reviewers
RKSimon
craig.topper
nikic
MaskRay
Commits
rGcaf22ec64a03: [UpdateTestChecks] More support for X86 exception handling

Diff Detail

Unit TestsFailed

TimeTest
3,790 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases/Linux::auto_memory_profile_test.cpp

Event Timeline

foad created this revision.May 5 2023, 9:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 9:19 AM
Herald added subscribers: luismarques, StephenFan, arichardson. · View Herald Transcript
foad requested review of this revision.May 5 2023, 9:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 9:19 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
foad added a child revision: D149953: [X86] Generate checks for 2012-01-10-UndefExceptionEdge.May 5 2023, 9:20 AM
Harbormaster completed remote builds in B230268: Diff 519893.May 5 2023, 10:07 AM
RKSimon accepted this revision.May 6 2023, 3:04 AM

LGTM

This revision is now accepted and ready to land.May 6 2023, 3:04 AM
This revision was landed with ongoing or failed builds.May 6 2023, 7:21 AM
Closed by commit rGcaf22ec64a03: [UpdateTestChecks] More support for X86 exception handling (authored by foad). · Explain Why
This revision was automatically updated to reflect the committed changes.
foad added a commit: rGcaf22ec64a03: [UpdateTestChecks] More support for X86 exception handling.

Revision Contents

PathSize
llvm/
test/
tools/
UpdateTestChecks/
update_llc_test_checks/
Inputs/
6 lines
24 lines
utils/
UpdateTestChecks/
2 lines

Diff 519893

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-basic.ll

Show All 24 Lines
define i32 @load() { define i32 @load() {
entry: entry:
%a = load i32, i32* @gv0 %a = load i32, i32* @gv0
%b = load i32, i32* @gv1 %b = load i32, i32* @gv1
%c = add i32 %a, %b %c = add i32 %a, %b
ret i32 %c ret i32 %c
} }
declare i32 @pers(...)
define i32 @eh() personality ptr @pers {
ret i32 0
}

llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/x86-basic.ll.expected

Show First 20 Lines • Show All 88 Lines • ▼ Show 20 Lines
; WIN-NEXT: addl gv1(%rip), %eax ; WIN-NEXT: addl gv1(%rip), %eax
; WIN-NEXT: retq ; WIN-NEXT: retq
entry: entry:
%a = load i32, i32* @gv0 %a = load i32, i32* @gv0
%b = load i32, i32* @gv1 %b = load i32, i32* @gv1
%c = add i32 %a, %b %c = add i32 %a, %b
ret i32 %c ret i32 %c
} }
declare i32 @pers(...)
define i32 @eh() personality ptr @pers {
; CHECK-LABEL: eh:
; CHECK: # %bb.0:
; CHECK-NEXT: xorl %eax, %eax
; CHECK-NEXT: retq
;
; PIC-LABEL: eh:
; PIC: # %bb.0:
; PIC-NEXT: xorl %eax, %eax
; PIC-NEXT: retq
;
; WIN-LABEL: eh:
; WIN: # %bb.0:
; WIN-NEXT: xorl %eax, %eax
; WIN-NEXT: retq
; WIN-NEXT: .Lfunc_end0:
; WIN-NEXT: .seh_handlerdata
; WIN-NEXT: .text
; WIN-NEXT: .seh_endproc
ret i32 0
}

llvm/utils/UpdateTestChecks/asm.py

Show All 12 Lines
# RegEx: this is where the magic happens. # RegEx: this is where the magic happens.
##### Assembly parser ##### Assembly parser
ASM_FUNCTION_X86_RE = re.compile( ASM_FUNCTION_X86_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*(@"?(?P=func)"?| -- Begin function (?P=func))\n(?:\s*\.?Lfunc_begin[^:\n]*:\n)?' r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*(@"?(?P=func)"?| -- Begin function (?P=func))\n(?:\s*\.?Lfunc_begin[^:\n]*:\n)?'
r'(?:\.L(?P=func)\$local:\n)?' # drop .L<func>$local: r'(?:\.L(?P=func)\$local:\n)?' # drop .L<func>$local:
r'(?:\s*\.type\s+\.L(?P=func)\$local,@function\n)?' # drop .type .L<func>$local r'(?:\s*\.type\s+\.L(?P=func)\$local,@function\n)?' # drop .type .L<func>$local
r'(?:[ \t]+.cfi_startproc\n|.seh_proc[^\n]+\n)?' # drop optional cfi r'(?:[ \t]*(?:\.cfi_startproc|\.cfi_personality|\.cfi_lsda|\.seh_proc|\.seh_handler)\b[^\n]*\n)*' # drop optional cfi
r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*' r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*'
r'^\s*(?:[^:\n]+?:\s*\n\s*\.size|\.cfi_endproc|\.globl|\.comm|\.(?:sub)?section|#+ -- End function)', r'^\s*(?:[^:\n]+?:\s*\n\s*\.size|\.cfi_endproc|\.globl|\.comm|\.(?:sub)?section|#+ -- End function)',
flags=(re.M | re.S)) flags=(re.M | re.S))
ASM_FUNCTION_ARM_RE = re.compile( ASM_FUNCTION_ARM_RE = re.compile(
r'^(?P<func>[0-9a-zA-Z_$]+):\n' # f: (name of function) r'^(?P<func>[0-9a-zA-Z_$]+):\n' # f: (name of function)
r'(?:\.L(?P=func)\$local:\n)?' # drop .L<func>$local: r'(?:\.L(?P=func)\$local:\n)?' # drop .L<func>$local:
r'(?:\s*\.type\s+\.L(?P=func)\$local,@function\n)?' # drop .type .L<func>$local r'(?:\s*\.type\s+\.L(?P=func)\$local,@function\n)?' # drop .type .L<func>$local
▲ Show 20 Lines • Show All 511 Lines • Show Last 20 Lines