This is an archive of the discontinued LLVM Phabricator instance.

[X86] Generate checks for 2012-01-10-UndefExceptionEdge
ClosedPublic

Authored by foad on May 5 2023, 6:09 AM.

Details

Summary

Also add -verify-machineinstrs to make it easier to catch a
MachineVerifier failure introduced by D149947.

Diff Detail

Event Timeline

foad created this revision.May 5 2023, 6:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 6:09 AM
foad requested review of this revision.May 5 2023, 6:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 5 2023, 6:09 AM
foad added inline comments.May 5 2023, 6:14 AM
llvm/utils/UpdateTestChecks/asm.py
21 ↗(On Diff #519829)

The function I was looking at had all this before the first label:

.cfi_startproc
.cfi_personality 155, L___gxx_personality_v0$non_lazy_ptr
.cfi_lsda 16, Lexception0
RKSimon accepted this revision.May 5 2023, 6:56 AM

LGTM - please commit the asm.py change separately though

This revision is now accepted and ready to land.May 5 2023, 6:56 AM
foad updated this revision to Diff 519895.May 5 2023, 9:20 AM

Rebase.

This revision was automatically updated to reflect the committed changes.