The beginning of the huge refactor on Triple class.
The aim is to implement triple-related features in more OOP way.
Details
- Reviewers
chandlerc lattner dylanmckay RKSimon pengfei
Diff Detail
Event Timeline
It is pretty arguable changes, because they are made in more OOP "Java-way". Since that I would be glad to discuss some design of architecture of my solution.
This commit just adds new classes, but does NOT integrate them with llvm itself yet.
I am in doubt about correct list of reviewers. And maybe we can discuss this solution somewhere else.
The beginning of the huge refactor on Triple class.
The aim is to implement triple-related features in more OOP way.
Is there an RFC for this (sorry I often miss things on Discourse) ? Please can you include the link in the summary.
I did not make RFC at Discourse. (Should I?)
I am newbie at LLVM project, so I do not fully understand how to contribute such major refactoring (and at first show my ideas to someone).
P.S. I read the policy again and find that I should make the page on the Discourse. Can anyone help me to do that in right way?
I made the post on Discourse: https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410
Hope I did it right
Stylistic comments, to help readers find the forest amid all the trees. :)
Probably should abbreviate Architecture as Arch everywhere, not just sometimes. It's a well-understood abbreviation.
llvm/include/llvm/TargetParser/Architecture/ArchitectureHelpers.h | ||
---|---|---|
8 | LLVM style is to use header guards | |
15 | A final class with a deleted constructor and only static methods seems like a more complicated way to define a namespace; so please just use a namespace. | |
llvm/lib/TargetParser/Architecture/CMakeLists.txt | ||
1 | The project prefers to have RTTI off. Where do you need this? | |
llvm/unittests/TargetParser/Architecture/CMakeLists.txt | ||
1 | The project prefers to have RTTI off. Where do you need this? |
llvm/include/llvm/TargetParser/Architecture/IDefaultFormatProvider.h | ||
---|---|---|
15 | If you could document everything that is public (and non-trivial things in general), that would help. Right now reading the patch is a bit hard.. |
LLVM style is to use header guards
(comment applies to all headers)