[BOLT] Make sure Mach-O binaries are actually linked

[jobnoorman]

Summary

Note that this issue is also solved by D147544.

[Amir]

Can you please add a test based on the issue found in D147544?

[jobnoorman]

Add test.

The test was taken from D149113 but fixed and the executable was converted to yaml.

[alexander-shaposhnikov]

to me LG

bolt/lib/Rewrite/MachORewriteInstance.cpp

530

yeah, i think it got lost

bolt/lib/Rewrite/MachORewriteInstance.cpp

void MachORewriteInstance::emitAndLink() {
 
   // Assign addresses to all sections. If key corresponds to the object
   // created by ourselves, call our regular mapping function. If we are
   // loading additional objects as part of runtime libraries for
   // instrumentation, treat them as extra sections.
   mapCodeSections();
   mapInstrumentationSection("__counters");
   mapInstrumentationSection("__tables");
+  RTDyld->finalizeWithMemoryManagerLocking();
 
           // TODO: Refactor addRuntimeLibSections to work properly on Mach-O
           // and use it here.
   //FIXME! Put this in RtLibrary->link
 //          mapInstrumentationSection("I__setup");
 //          mapInstrumentationSection("I__fini");
 //          mapInstrumentationSection("I__data");
 //          mapInstrumentationSection("I__text");