[AMDGPU][Disassembler] Pre-commit a test on an error message generated in an instruction comment.

[kosarev]

Updated.

[arsenm]

Test name could be more descriptive. Current name makes it sound like it's checking for any comments

[kosarev]

Test name could be more descriptive. Current name makes it sound like it's checking for any comments

Well, it does. We don't want any comments for this instruction.

[kosarev]

Committed as rGc08dc8b5fbd0e44d5cac7738ffee724d91a26243.

[arsenm]

Still think test needs renaming

[arsenm]

In D149048#4298585, @kosarev wrote:

Test name could be more descriptive. Current name makes it sound like it's checking for any comments

Well, it does. We don't want any comments for this instruction.

Yes, for *this* instruction. The general name sounds like it's for testing that comments are emitted in general

[kosarev]

Yes, for *this* instruction. The general name sounds like it's for testing that comments are emitted in general

That indeed was the idea -- to introduce a general test for comments and not just for this particular instruction.

llvm/test/MC/Disassembler/AMDGPU/comments.txt

+# RUN: llvm-mc -assemble -triple=amdgcn--amdhsa -mcpu=gfx1100 -filetype=obj %s -o - | \
+# RUN:   llvm-objdump -d - | FileCheck %s
+
+; CHECK: v_perm_b32 v14, v52, v51, 0x5040100 // 000000000000: D644000E 03FE6734 05040100 ; Error: cannot read literal, inst bytes left 0{{$}}
+  v_perm_b32 v14, v52, v51, 0x5040100