This is an archive of the discontinued LLVM Phabricator instance.

Differential D149026

[BOLT] Fix many tests detected as unsupported
ClosedPublic

Authored by jobnoorman on Apr 23 2023, 9:51 AM.

Details

Reviewers
rafauler
maksfb
yota9
Amir
urnathan
Commits
rGb3780af3b3cd: [BOLT] Fix many tests detected as unsupported
Summary

Since D148847, many tests are detected as being unsupported. This is
caused by BOLT_TARGETS_TO_BUILD being ;-separated whereas the previously
used TARGETS_TO_BUILD is space-separated.

This patch fixes this by creating config.targets lit.cfg.py by splitting
on ';'.

Diff Detail

Event Timeline

jobnoorman created this revision.Apr 23 2023, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 9:51 AM
Herald added subscribers: asb, treapster, pmatos, ayermolo. · View Herald Transcript
jobnoorman requested review of this revision.Apr 23 2023, 9:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 23 2023, 9:51 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B227551: Diff 516184.Apr 23 2023, 9:58 AM
rafauler accepted this revision.Apr 24 2023, 11:01 AM
This revision is now accepted and ready to land.Apr 24 2023, 11:01 AM
Closed by commit rGb3780af3b3cd: [BOLT] Fix many tests detected as unsupported (authored by jobnoorman, committed by rafauler). · Explain WhyApr 24 2023, 11:39 AM
This revision was automatically updated to reflect the committed changes.
rafauler added a commit: rGb3780af3b3cd: [BOLT] Fix many tests detected as unsupported.

Revision Contents

PathSize
bolt/
test/
2 lines

Diff 516184

bolt/test/lit.cfg.py

Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Lines
llvm_config.feature_config( llvm_config.feature_config(
[('--assertion-mode', {'ON': 'asserts'}), [('--assertion-mode', {'ON': 'asserts'}),
('--cxxflags', {r'-D_GLIBCXX_DEBUG\b': 'libstdcxx-safe-mode'}), ('--cxxflags', {r'-D_GLIBCXX_DEBUG\b': 'libstdcxx-safe-mode'}),
('--targets-built', calculate_arch_features) ('--targets-built', calculate_arch_features)
]) ])
config.targets = frozenset(config.targets_to_build.split()) config.targets = frozenset(config.targets_to_build.split(';'))