This is an archive of the discontinued LLVM Phabricator instance.

ValueTracking: Implement computeKnownFPClass for log
ClosedPublic

Authored by arsenm on Apr 17 2023, 11:17 AM.

Diff Detail

Event Timeline

arsenm created this revision.Apr 17 2023, 11:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 11:17 AM
arsenm requested review of this revision.Apr 17 2023, 11:17 AM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: wdng. · View Herald Transcript
foad added inline comments.Apr 18 2023, 2:27 AM
llvm/lib/Analysis/ValueTracking.cpp
4390

Blindly propagating InterestedClasses seems wrong again. E.g. if InterestedClasses contains fcNegInf then the value you pass down should contain fcZero.

4395

Why is this inside the NeverPosInf check? Doesn't it also need a NeverNan check?

arsenm marked an inline comment as done.Apr 25 2023, 4:20 AM
arsenm added inline comments.
llvm/lib/Analysis/ValueTracking.cpp
4390

It can't be incorrect, this can only improve precision. It's hard to get these right without relevant queries wired up

arsenm updated this revision to Diff 516744.Apr 25 2023, 4:20 AM
foad accepted this revision.Apr 25 2023, 6:03 AM
foad added inline comments.
llvm/lib/Analysis/ValueTracking.cpp
4390

It can't be incorrect, this can only improve precision.

Ack, I get that now.

4511

If InterestedClasses includes any nan, InterestedSrcs should include fcNan and the ordered-less-than-zero stuff.

This revision is now accepted and ready to land.Apr 25 2023, 6:03 AM