This is an archive of the discontinued LLVM Phabricator instance.

Differential D148511

[BOLT][test] Update AArch64/r_aarch64_prelxx.s test
ClosedPublic

Authored by Amir on Apr 17 2023, 3:42 AM.

Details

Reviewers
rafauler
maksfb
MaskRay
Group Reviewers
Restricted Project
Commits
rG286b5071f1b5: [BOLT][test] Update AArch64/r_aarch64_prelxx.s test
Summary

Update section flags and type after https://reviews.llvm.org/D148386

Diff Detail

Event Timeline

Amir created this revision.Apr 17 2023, 3:42 AM
Herald added a reviewer: rafauler. · View Herald TranscriptApr 17 2023, 3:42 AM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo, kristof.beyls. · View Herald Transcript
Amir requested review of this revision.Apr 17 2023, 3:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 3:42 AM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
Harbormaster completed remote builds in B226046: Diff 514153.Apr 17 2023, 3:50 AM
Amir added a subscriber: MaskRay.Apr 17 2023, 3:58 AM
Amir added a subscriber: jobnoorman.Apr 17 2023, 7:37 AM
rafauler accepted this revision.Apr 17 2023, 1:06 PM

LGTM

This revision is now accepted and ready to land.Apr 17 2023, 1:06 PM
zequanwu mentioned this in D148386: [MCParser] Reject processor-specific section flags not known by the current target.Apr 17 2023, 1:58 PM
MaskRay accepted this revision.Apr 17 2023, 2:15 PM

FYI In other components, [test] is much more common than [TEST] ..

Amir retitled this revision from [BOLT][TEST] Update AArch64/r_aarch64_prelxx.s test to [BOLT][test] Update AArch64/r_aarch64_prelxx.s test.Apr 17 2023, 2:20 PM
Closed by commit rG286b5071f1b5: [BOLT][test] Update AArch64/r_aarch64_prelxx.s test (authored by Amir). · Explain WhyApr 17 2023, 2:33 PM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG286b5071f1b5: [BOLT][test] Update AArch64/r_aarch64_prelxx.s test.

Revision Contents

PathSize
bolt/
test/
AArch64/
2 lines

Diff 514411

bolt/test/AArch64/r_aarch64_prelxx.s

Show All 37 Lines// CHECKPREL64: [[#DATATABLEADDR + 8 - 12 + VALUE]] <_start>:
.align 4 .align 4
.globl _start .globl _start
.type _start, %function .type _start, %function
_start: _start:
adr x0, datatable adr x0, datatable
mov x0, #0 mov x0, #0
ret ret
.section .dummy, "da" .section .dummy, "a", @progbits
dummy: dummy:
.word 0 .word 0
.data .data
.align 8 .align 8
datatable: datatable:
.hword dummy - datatable .hword dummy - datatable
.align 2 .align 2
.word _start - datatable .word _start - datatable
.xword _start - datatable .xword _start - datatable