This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Make ElementsAttr inherit from TypedAttr
ClosedPublic

Authored by rkayaith on Apr 16 2023, 9:12 PM.

Details

Summary

This allows implicit conversion from ElementsAttr to TypedAttr, but
required renaming the ElementsAttr::getType() interface method to
getShapedType.

Diff Detail

Event Timeline

rkayaith created this revision.Apr 16 2023, 9:12 PM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
rkayaith added inline comments.Apr 16 2023, 10:30 PM
mlir/include/mlir/IR/BuiltinAttributeInterfaces.td
182–184

I'm not sure this is the best name, open to suggestions.

rkayaith published this revision for review.Apr 16 2023, 10:33 PM
rriddle accepted this revision.Apr 16 2023, 10:44 PM
This revision is now accepted and ready to land.Apr 16 2023, 10:44 PM
This revision was automatically updated to reflect the committed changes.