This is an archive of the discontinued LLVM Phabricator instance.

remove Demangle/StringView.h
ClosedPublic

Authored by nickdesaulniers on Apr 14 2023, 3:26 PM.

Details

Reviewers
EricWF
compnerd
phosek
MaskRay
Group Reviewers
Restricted Project
Commits
rG217709cbae34: remove Demangle/StringView.h
Summary

Now that we've converted libcxxabi and llvm Demangle to use
std::string_view, this code no longer has any users. Bye bye!

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 14 2023, 3:26 PM
nickdesaulniers requested review of this revision.Apr 14 2023, 3:26 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 14 2023, 3:26 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
nickdesaulniers retitled this revision from [RFC] remove Demange/StringView.h to [RFC] remove Demangle/StringView.h.
  • fix typo
Harbormaster completed remote builds in B225747: Diff 513771.
  • remove StringView unittests
nickdesaulniers retitled this revision from [RFC] remove Demangle/StringView.h to remove Demangle/StringView.h.
nickdesaulniers edited the summary of this revision. (Show Details)
  • resolve TODOs, rebase
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 2:26 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
MaskRay accepted this revision.Apr 19 2023, 1:51 PM

LGTM, but this can only be accepted from a member of #libc_abi

phosek accepted this revision.Apr 19 2023, 10:51 PM

LGTM

This revision is now accepted and ready to land.Apr 19 2023, 10:51 PM
  • rebase for presubmit testing
MaskRay accepted this revision.May 31 2023, 8:24 PM
This revision was automatically updated to reflect the committed changes.
llvm/include/llvm/Demangle/README.txt