This is an archive of the discontinued LLVM Phabricator instance.

Differential D148547

Revert "[ADT] add StringViewExtras llvm::starts_with for std::string_view"
ClosedPublic

Authored by nickdesaulniers on Apr 17 2023, 10:57 AM.

Details

Reviewers
MaskRay
erichkeane
chapuni
Commits
rGb0b2b2e047ca: Revert "[ADT] add StringViewExtras llvm::starts_with for std::string_view"
Summary

This reverts commit d6d30dd9590b41fbcdc88b43767b27a31bfb1c73.

These helpers were added to be used by LLVMDemangle, which would be a
layering violation for that to depend on LLVMSupport. Undo this commit,
and I'll these these directly in LLVMDemangle.

Diff Detail

Revision Contents

PathSize
llvm/
include/
llvm/
ADT/
unittests/
ADT/
1 line

Diff 514382

llvm/include/llvm/ADT/StringViewExtras.h

  • This file was deleted.
//===- llvm/ADT/StringViewExtras.h - Useful string_view functions C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
///
/// \file
/// This file contains some functions that are useful when dealing with
/// string_views.
///
//===----------------------------------------------------------------------===//
#ifndef LLVM_ADT_STRINGVIEWEXTRAS_H
#define LLVM_ADT_STRINGVIEWEXTRAS_H
#include <string_view>
namespace llvm {
// FIXME: std::string_view::starts_with is not available until C++20. Once LLVM
// is upgraded to C++20, remove this header and users.
inline constexpr bool starts_with(std::string_view self, char C) {
return !self.empty() && self.front() == C;
}
inline constexpr bool starts_with(std::string_view haystack,
std::string_view needle) {
return haystack.substr(0, needle.size()) == needle;
}
} // end namespace llvm
#endif // LLVM_ADT_STRINGVIEWEXTRAS_H

llvm/unittests/ADT/CMakeLists.txt

Show First 20 Lines • Show All 73 Lines • ▼ Show 20 Linesadd_llvm_unittest(ADTTests
SparseMultiSetTest.cpp SparseMultiSetTest.cpp
SparseSetTest.cpp SparseSetTest.cpp
StatisticTest.cpp StatisticTest.cpp
StringExtrasTest.cpp StringExtrasTest.cpp
StringMapTest.cpp StringMapTest.cpp
StringRefTest.cpp StringRefTest.cpp
StringSetTest.cpp StringSetTest.cpp
StringSwitchTest.cpp StringSwitchTest.cpp
StringViewExtrasTest.cpp
TinyPtrVectorTest.cpp TinyPtrVectorTest.cpp
TwineTest.cpp TwineTest.cpp
TypeSwitchTest.cpp TypeSwitchTest.cpp
TypeTraitsTest.cpp TypeTraitsTest.cpp
) )
target_link_libraries(ADTTests PRIVATE LLVMTestingSupport) target_link_libraries(ADTTests PRIVATE LLVMTestingSupport)
add_dependencies(ADTTests intrinsics_gen) add_dependencies(ADTTests intrinsics_gen)

llvm/unittests/ADT/StringViewExtrasTest.cpp

  • This file was deleted.
//===- StringExtrasTest.cpp - Unit tests for String extras ----------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "llvm/ADT/StringViewExtras.h"
#include "llvm/Support/raw_ostream.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"
#include <string_view>
using namespace llvm;
TEST(StringViewExtrasTest, starts_with) {
std::string haystack = "hello world";
EXPECT_TRUE(llvm::starts_with(haystack, 'h'));
EXPECT_FALSE(llvm::starts_with(haystack, '\0'));
EXPECT_TRUE(llvm::starts_with(haystack, "hello"));
// TODO: should this differ from \0?
EXPECT_TRUE(llvm::starts_with(haystack, ""));
std::string empty;
EXPECT_FALSE(llvm::starts_with(empty, 'h'));
EXPECT_FALSE(llvm::starts_with(empty, '\0'));
EXPECT_FALSE(llvm::starts_with(empty, "hello"));
// TODO: should this differ from \0?
EXPECT_TRUE(llvm::starts_with(empty, ""));
}
llvm/include/llvm/ADT/StringViewExtras.h