This is an archive of the discontinued LLVM Phabricator instance.

[FPEnv][LangRef] Update doc for strictfp attribute
ClosedPublic

Authored by kpn on Apr 12 2023, 8:58 AM.

Details

Summary

Based on the direction of IR Verifier changes in D146845, this documentation needs to be updated.

Diff Detail

Event Timeline

kpn created this revision.Apr 12 2023, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 8:58 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
kpn requested review of this revision.Apr 12 2023, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 8:58 AM
arsenm accepted this revision.Apr 13 2023, 6:50 AM

I'd say this is already implied by the current wording, but doesn't hurt to be explicit

This revision is now accepted and ready to land.Apr 13 2023, 6:50 AM

Though I am wondering if there's any real reason to require anything of an indirect call site

kpn added a comment.Apr 13 2023, 6:57 AM

Though I am wondering if there's any real reason to require anything of an indirect call site

What if an optimization propagates a constant value into an indirect call? That would make it possible for the indirect call to become direct.

This revision was landed with ongoing or failed builds.Apr 14 2023, 8:16 AM
This revision was automatically updated to reflect the committed changes.