This is an archive of the discontinued LLVM Phabricator instance.

[clang] Allow attributes to be constructed from keyword tokens
ClosedPublic

Authored by rsandifo-arm on Apr 12 2023, 3:06 AM.

Details

Summary

This patch adds an extra AttributeCommonInfo::Form constructor
for keywords, represented by their TokenKind. This isn't a
win on its own, but it helps with later patches.

No functional change intended.

Diff Detail

Event Timeline

rsandifo-arm created this revision.Apr 12 2023, 3:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 3:06 AM
rsandifo-arm requested review of this revision.Apr 12 2023, 3:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 3:06 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Again, not sold on value, but no problems with the patch itself.

erichkeane accepted this revision.Apr 12 2023, 6:43 AM

Later patches show enough value to this, I'm OK with it. Thanks!

This revision is now accepted and ready to land.Apr 12 2023, 6:43 AM