This is an archive of the discontinued LLVM Phabricator instance.

Differential D148000

[compiler-rt] [test] Remove a leftover XFAIL
ClosedPublic

Authored by mstorsjo on Apr 11 2023, 2:03 AM.

Details

Reviewers
aeubanks
omjavaid
phosek
alvinhochun
vitalybuka
Commits
rGea47dcf2c85d: [compiler-rt] [test] Remove a leftover XFAIL
Summary

This test succeeds on aarch64 windows now (tested both in mingw
mode and with clang-cl), most probably since commit
ccd96b3e03e18653e909852bfef105fc10782acb / D146667 ([builtins][test] Fix
divmodti4_test.c on Windows).

Diff Detail

Unit TestsFailed

TimeTest
130 msx64 debian > LLVM.Transforms/LoopVectorize/AArch64::strict-fadd-cost.ll
130 msx64 debian > LLVM.Transforms/LoopVectorize/AArch64::sve-strict-fadd-cost.ll

Event Timeline

mstorsjo created this revision.Apr 11 2023, 2:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2023, 2:03 AM
Herald added subscribers: Enna1, kristof.beyls, dberris. · View Herald Transcript
mstorsjo requested review of this revision.Apr 11 2023, 2:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2023, 2:03 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B224720: Diff 512370.Apr 11 2023, 2:24 AM
vitalybuka accepted this revision.Apr 11 2023, 9:59 AM
This revision is now accepted and ready to land.Apr 11 2023, 9:59 AM
This revision was landed with ongoing or failed builds.Apr 12 2023, 12:18 AM
Closed by commit rGea47dcf2c85d: [compiler-rt] [test] Remove a leftover XFAIL (authored by mstorsjo). · Explain Why
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rGea47dcf2c85d: [compiler-rt] [test] Remove a leftover XFAIL.

Revision Contents

PathSize
compiler-rt/
test/
builtins/
Unit/
1 line

Diff 512370

compiler-rt/test/builtins/Unit/divmodti4_test.c

// XFAIL: target=aarch64-{{.*}}-windows-{{.*}}
// RUN: %clang_builtins %s %librt -o %t && %run %t // RUN: %clang_builtins %s %librt -o %t && %run %t
// REQUIRES: librt_has_divmodti4 // REQUIRES: librt_has_divmodti4
// REQUIRES: int128 // REQUIRES: int128
//===-- divmodti4_test.c - Test __divmodti4 -------------------------------===// //===-- divmodti4_test.c - Test __divmodti4 -------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
▲ Show 20 Lines • Show All 83 Lines • Show Last 20 Lines