This is an archive of the discontinued LLVM Phabricator instance.

Differential D146667

[builtins][test] Fix divmodti4_test.c on Windows
ClosedPublic

Authored by aeubanks on Mar 22 2023, 3:57 PM.

Details

Reviewers
craig.topper
MaskRay
Commits
rGccd96b3e03e1: [builtins][test] Fix divmodti4_test.c on Windows
Summary

By making the 64 bit integer literals unsigned. Otherwise some of them
are unexpectedly sign extended (and the compiler rightly diagnosed this
with warnings)

Initially added in D80506.

Diff Detail

Event Timeline

aeubanks created this revision.Mar 22 2023, 3:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 3:57 PM
Herald added a subscriber: Enna1. · View Herald Transcript
aeubanks requested review of this revision.Mar 22 2023, 3:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 3:57 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
aeubanks edited the summary of this revision. (Show Details)Mar 22 2023, 3:57 PM
aeubanks added a reviewer: craig.topper.
Harbormaster completed remote builds in B221157: Diff 507533.Mar 22 2023, 4:15 PM
MaskRay accepted this revision.Mar 23 2023, 1:14 PM
This revision is now accepted and ready to land.Mar 23 2023, 1:14 PM
This revision was landed with ongoing or failed builds.Mar 23 2023, 7:09 PM
Closed by commit rGccd96b3e03e1: [builtins][test] Fix divmodti4_test.c on Windows (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rGccd96b3e03e1: [builtins][test] Fix divmodti4_test.c on Windows.
mstorsjo mentioned this in D148000: [compiler-rt] [test] Remove a leftover XFAIL.Apr 11 2023, 2:03 AM
mstorsjo mentioned this in rGea47dcf2c85d: [compiler-rt] [test] Remove a leftover XFAIL.Apr 12 2023, 12:18 AM

Revision Contents

PathSize
compiler-rt/
test/
builtins/
Unit/
32 lines

Diff 507941

compiler-rt/test/builtins/Unit/divmodti4_test.c

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Linesint test__divmodti4(ti_int a, ti_int b, ti_int expected_q, ti_int expected_r) {
} }
return !(q == expected_q && r == expected_r); return !(q == expected_q && r == expected_r);
} }
char assumption_1[sizeof(ti_int) == 2*sizeof(di_int)] = {0}; char assumption_1[sizeof(ti_int) == 2*sizeof(di_int)] = {0};
tu_int tests[][4] = tu_int tests[][4] =
{ {
{ (ti_int) 0, (ti_int) 1, (ti_int) 0, (ti_int) 0 }, { (ti_int) 0, (ti_int) 1, (ti_int) 0, (ti_int) 0 },
{ (ti_int) 0, (ti_int)-1, (ti_int) 0, (ti_int) 0 }, { (ti_int) 0, (ti_int)-1, (ti_int) 0, (ti_int) 0 },
{ (ti_int) 2, (ti_int) 1, (ti_int) 2, (ti_int) 0 }, { (ti_int) 2, (ti_int) 1, (ti_int) 2, (ti_int) 0 },
{ (ti_int) 2, (ti_int)-1, (ti_int)-2, (ti_int) 0 }, { (ti_int) 2, (ti_int)-1, (ti_int)-2, (ti_int) 0 },
{ (ti_int)-2, (ti_int) 1, (ti_int)-2, (ti_int) 0 }, { (ti_int)-2, (ti_int) 1, (ti_int)-2, (ti_int) 0 },
{ (ti_int)-2, (ti_int)-1, (ti_int) 2, (ti_int) 0 }, { (ti_int)-2, (ti_int)-1, (ti_int) 2, (ti_int) 0 },
{ (ti_int) 5, (ti_int) 3, (ti_int) 1, (ti_int) 2 }, { (ti_int) 5, (ti_int) 3, (ti_int) 1, (ti_int) 2 },
{ (ti_int) 5, (ti_int)-3, (ti_int)-1, (ti_int) 2 }, { (ti_int) 5, (ti_int)-3, (ti_int)-1, (ti_int) 2 },
{ (ti_int)-5, (ti_int) 3, (ti_int)-1, (ti_int)-2 }, { (ti_int)-5, (ti_int) 3, (ti_int)-1, (ti_int)-2 },
{ (ti_int)-5, (ti_int)-3, (ti_int) 1, (ti_int)-2 }, { (ti_int)-5, (ti_int)-3, (ti_int) 1, (ti_int)-2 },
{ (ti_int)0x8000000000000000LL << 64 | 0, (ti_int) 1, (ti_int)0x8000000000000000LL << 64 | 0, (ti_int)0x0LL }, { (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int) 1, (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int)0x0LL },
{ (ti_int)0x8000000000000000LL << 64 | 0, (ti_int)-1, (ti_int)0x8000000000000000LL << 64 | 0, (ti_int)0x0LL }, { (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int)-1, (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int)0x0LL },
{ (ti_int)0x8000000000000000LL << 64 | 0, (ti_int)-2, (ti_int)0x4000000000000000LL << 64 | 0, (ti_int)0x0LL }, { (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int)-2, (ti_int)0x4000000000000000ULL << 64 | 0, (ti_int)0x0LL },
{ (ti_int)0x8000000000000000LL << 64 | 0, (ti_int) 2, (ti_int)0xC000000000000000LL << 64 | 0, (ti_int)0x0LL }, { (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int) 2, (ti_int)0xC000000000000000ULL << 64 | 0, (ti_int)0x0LL },
{ (ti_int)0x8000000000000000LL << 64 | 0, (ti_int)-3, (ti_int)0x2AAAAAAAAAAAAAAALL << 64 | 0xAAAAAAAAAAAAAAAALL, (ti_int)-2 }, { (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int)-3, (ti_int)0x2AAAAAAAAAAAAAAAULL << 64 | 0xAAAAAAAAAAAAAAAAULL, (ti_int)-2 },
{ (ti_int)0x8000000000000000LL << 64 | 0, (ti_int) 3, (ti_int)0xD555555555555555LL << 64 | 0x5555555555555556LL, (ti_int)-2 }, { (ti_int)0x8000000000000000ULL << 64 | 0, (ti_int) 3, (ti_int)0xD555555555555555ULL << 64 | 0x5555555555555556ULL, (ti_int)-2 },
}; };
#endif #endif
int main() int main()
{ {
#ifdef CRT_HAS_128BIT #ifdef CRT_HAS_128BIT
const unsigned N = sizeof(tests) / sizeof(tests[0]); const unsigned N = sizeof(tests) / sizeof(tests[0]);
Show All 11 Lines