[MLIR] Add an assert in Operation::getOpResultImpl for out of range result

[xgupta]

Summary

This fix https://github.com/llvm/llvm-project/issues/61962.

Calling op->getResult(0) on a function like operation with no results
returned a garbage pointer.

This patch add assert to check number is in range.

[xgupta]

update with clang-format

[rriddle]

The assert should be at the top of the function

[xgupta]

address comment

[rriddle]

Nice job with the fix!

[xgupta]

Thanks for reviewing on sunday :-)
Happy day!

[xgupta]

Hi,

It seems it broke buildbot for Dialect/SparseTensor/codegen.mlir test case and some other flang testcase also.

I am not sure how to fix those, Someone with MLIR knowledge PTAL otherwise feel free to revert it if requires.

[mehdi_amini]

In D147883#4254616, @xgupta wrote:

Hi,

It seems it broke buildbot for Dialect/SparseTensor/codegen.mlir test case and some other flang testcase also.

I am not sure how to fix those, Someone with MLIR knowledge PTAL otherwise feel free to revert it if requires.

If a bot is broken and you don't have an immediate fix: please revert immediately!

[mehdi_amini]

(also: you have pre-merge testing happening on Phabricator revision that can hint at some of these before pushing)

[xgupta]

Thanks for the revert.

Seems @frgossen fixed the SparseTensor issue, can someone from Flang team take a look at this buildbot - https://lab.llvm.org/buildbot/#/builders/197/builds/4476.
The issue might be at -
https://github.com/llvm/llvm-project/blob/d374d474698001784d0bc0fce4ddfd08fe7d3545/flang/lib/Lower/ConvertCall.cpp#L222 or maybe somewhere in flang/lib/Lower/ConvertExpr.cpp.

CC @clementval @jeanPerier

[clementval]

In D147883#4255854, @xgupta wrote:

Thanks for the revert.

Seems @frgossen fixed the SparseTensor issue, can someone from Flang team take a look at this buildbot - https://lab.llvm.org/buildbot/#/builders/197/builds/4476.
The issue might be at -
https://github.com/llvm/llvm-project/blob/d374d474698001784d0bc0fce4ddfd08fe7d3545/flang/lib/Lower/ConvertCall.cpp#L222 or maybe somewhere in flang/lib/Lower/ConvertExpr.cpp.

CC @clementval @jeanPerier

This would be fixed by D147959

[xgupta]

Reland in https://reviews.llvm.org/rG6a621795e03760e26acec7d3b612ba0c0a0f2e7e.

mlir/include/mlir/IR/Operation.h

detail::InlineOpResult *getInlineOpResult(unsigned resultNumber) {
     // Inline results are stored in reverse order before the operation in
     // memory.
     return reinterpret_cast<detail::InlineOpResult *>(this) - ++resultNumber;
   }
 
   /// Returns a pointer to the use list for the given result, which may be
   /// either inline or out-of-line.
   detail::OpResultImpl *getOpResultImpl(unsigned resultNumber) {
+    assert(resultNumber < getNumResults() &&
+           "Result number is out of range for operation");
     unsigned maxInlineResults = detail::OpResultImpl::getMaxInlineResults();
     if (resultNumber < maxInlineResults)
       return getInlineOpResult(resultNumber);
     return getOutOfLineOpResult(resultNumber - maxInlineResults);
   }
 
   /// Provide a 'getParent' method for ilist_node_with_parent methods.
   /// We mark it as a const function because ilist_node_with_parent specifically