This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Add tool dependencies in runtimes mode
ClosedPublic

Authored by jhuber6 on Apr 5 2023, 12:27 PM.

Details

Summary

The OpenMP offloading device runtime depends on multiple tools. We
should ensure that these tools are build before invoking the OpenMP
build.

Diff Detail

Unit TestsFailed

Event Timeline

jhuber6 created this revision.Apr 5 2023, 12:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 12:27 PM
jhuber6 requested review of this revision.Apr 5 2023, 12:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 12:27 PM
tra accepted this revision.Apr 5 2023, 12:40 PM

LGTM with a couple of nits.

llvm/runtimes/CMakeLists.txt
386

Should AND OPENMP_ENABLE_LIBOMPTARGET) be moved to the top-level if?

388

Nit: stray <TAB> character.

This revision is now accepted and ready to land.Apr 5 2023, 12:40 PM
jhuber6 marked an inline comment as done.Apr 5 2023, 1:07 PM
jhuber6 added inline comments.
llvm/runtimes/CMakeLists.txt
386

These dependencies are only relevant for libomptarget. So if we're only building libomp they can be ignored.

This revision was landed with ongoing or failed builds.Apr 5 2023, 1:15 PM
This revision was automatically updated to reflect the committed changes.