[mlir][llvm] Drop `ResumeOp::verify()` function

[victor-eds]

Summary

In patch https://reviews.llvm.org/rG478bd0735fc094d3af37e9791df5118a402ae7a7,
this function was changed so that it always returns success(). Drop this
and explicitly state it won't be generated in the .td file and explain
llvm.resume restrictions will be checked in LLVMFuncOp::verify().

[gysit]

Thanks for the cleanup!

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

if (failed(mlirOperands))
       return failure();
     $_op = $_builder.create<LLVM::ReturnOp>($_location, *mlirOperands);
   }];
 }
 
 def LLVM_ResumeOp : LLVM_TerminatorOp<"resume"> {
   let arguments = (ins LLVM_Type:$value);
   let assemblyFormat = "$value attr-dict `:` type($value)";
-  let hasVerifier = 1;
+  // Consistency of llvm.resume value types is checked in LLVMFuncOp::verify().
+  let hasVerifier = false;
   string llvmInstName = "Resume";
   string llvmBuilder = [{ builder.CreateResume($value); }];
   string mlirBuilder = [{
     $_op = $_builder.create<LLVM::ResumeOp>($_location, $value);
   }];
 }
 def LLVM_UnreachableOp : LLVM_TerminatorOp<"unreachable"> {
   let assemblyFormat = "attr-dict";

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

if (expectedType != getArg().getType()) {
     InFlightDiagnostic diag = emitOpError("mismatching result types");
     diag.attachNote(parent->getLoc()) << "when returning from function";
     return diag;
   }
   return success();
 }
 
 //===----------------------------------------------------------------------===//
-// ResumeOp
-//===----------------------------------------------------------------------===//
-
-LogicalResult ResumeOp::verify() {
-  // Consistency of llvm.resume value types is checked in LLVMFuncOp::verify().
-
-  // No check for personality of function - landingpad op verifies it.
-  return success();
-}
-
-//===----------------------------------------------------------------------===//
 // Verifier for LLVM::AddressOfOp.
 //===----------------------------------------------------------------------===//
 
 static Operation *parentLLVMModule(Operation *op) {
   Operation *module = op->getParentOp();
   while (module && !satisfiesLLVMModule(module))
     module = module->getParentOp();
   assert(module && "unexpected operation outside of a module");