Yep, I think we can use a single comment. Thanks for the quick review!

Drop similar doc comments

LGTM, thanks!

Thanks for the quick reviews!

In D148313#4267806, @gysit wrote:

LGTM, feel free to move the exception related tests into a separate test file, e.g. exception.ll, now that you are extending test coverage and functionality!

Thanks for the quick review! I've addressed your comments already.

Address comments

Thanks for the comments everyone! I'll land this now.

Moved to https://reviews.llvm.org/D146968

Improve readability

Rename var

Address comments

In D146968#4226524, @gysit wrote:

the type equality check should move into the llvm.func

I think moving the verifier to llvm.func sounds like a good idea. Then only a single pass is needed and there is no need to handle possible issues with non-existing parent functions. I would even consider moving the logic in https://reviews.llvm.org/D145802 to the same verifier. LLVM's verifier also works with a single pass and a global variable that is used for checking the types of landing pad and resume ops at once:

https://github.com/llvm/llvm-project/blob/15f52c1502e6aa2f7553393d76da92b21c7cf493/llvm/lib/IR/Verifier.cpp#L309

An additional advantage of the solution is that the verifier only runs if the landing pad operations are part of an llvm.func. If not, for example, during testing or while the IR is in a transient state in between lowering passes the verifier does not run. This behavior is in line with the existing verifier that only checks for the personality function if the landing pad op is part of a llvm.func.

Check type consistency in llvm.func verifier

In D146968#4224521, @Dinistro wrote:

It seems a bit wasteful to walk all the landingpads for each of the landingpads, but there might not be another way.

I addressed your comments already

Drop braces

Add test

Address review comments

Run tests

Rebase

Drop include

Allow nested ops

In D145802#4223771, @zero9178 wrote:

In D145802#4223741, @victor-eds wrote:

In D145802#4219686, @zero9178 wrote:

• LLVMs verifier seems to work differently by checking that ALL landing pads and resume instructions use consistent types: https://github.com/llvm/llvm-project/blob/b2c48559c882fd558f91e471c4d23ea7b0c6e718/llvm/lib/IR/Verifier.cpp#L4196 This seems contrary to what the langref says however which is confusing to me.

Yes, I saw that the code differs from the spec. According to the specification of the landingpad instruction:

The ‘landingpad’ instruction defines the values which are set by the personality function upon re-entry to the function, and therefore the “result type” of the landingpad instruction. As with calling conventions, how the personality function results are represented in LLVM IR is target specific.

I'd argue it would make sense to check every llvm.landingpad operation in a function has the same type (not sure if we should check it in llvm.resume's verifier). If you don't mind, I can address that in a different patch to keep this one small and simple and separate concerns.

I think it is fine as is. Making the verifier not have false positives is much more important than catching false negatives.

LGTM, but please wait a day or two for others to check as well. Ading some extra reviewers for visibility as well.

Assume all llvm.landingpad operations have the same type.

In D145802#4219686, @zero9178 wrote:

• LLVMs verifier seems to work differently by checking that ALL landing pads and resume instructions use consistent types: https://github.com/llvm/llvm-project/blob/b2c48559c882fd558f91e471c4d23ea7b0c6e718/llvm/lib/IR/Verifier.cpp#L4196 This seems contrary to what the langref says however which is confusing to me.

Use Type instead of const auto and use opaque pointers in tests.

Ping

Add attribute name to the dialect

LGTM. Totally missed that. Thanks.

Apply suggested changes

Missed that. Thanks. This should handle this behavior change.

Add boolean parameter to split SetCC operand or not

Done

Apply suggested changes

Simplify code

Done

Use SplitMask

Add SplitVecOp_Gather tests for VP_GATHER

Rename variable

Share code

Update tests

Add assertions in new function

Update tests

Done

Copy SDValue instead of passing reference

Fixing sequential FP reduction issues