Page MenuHomePhabricator

victor-eds (Victor Perez)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 26 2021, 3:42 AM (8 w, 2 d)

Recent Activity

Fri, Jan 21

victor-eds added inline comments to D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.
Fri, Jan 21, 11:14 AM · Restricted Project
victor-eds added a comment to D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Done

Fri, Jan 21, 11:11 AM · Restricted Project
victor-eds updated the diff for D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Apply suggested changes

Fri, Jan 21, 11:10 AM · Restricted Project
victor-eds updated the diff for D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Simplify code

Fri, Jan 21, 10:59 AM · Restricted Project
victor-eds added a comment to D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Done

Fri, Jan 21, 10:06 AM · Restricted Project
victor-eds added reviewers for D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter: frasercrmck, craig.topper, rogfer01, simoll, RKSimon.
Fri, Jan 21, 10:04 AM · Restricted Project
victor-eds updated the diff for D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Use SplitMask

Fri, Jan 21, 9:59 AM · Restricted Project
victor-eds updated the diff for D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Add SplitVecOp_Gather tests for VP_GATHER

Fri, Jan 21, 9:52 AM · Restricted Project
victor-eds updated the diff for D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Rename variable

Fri, Jan 21, 9:31 AM · Restricted Project
victor-eds updated the diff for D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.

Share code

Fri, Jan 21, 9:28 AM · Restricted Project

Thu, Jan 20

victor-eds requested review of D117760: [LegalizeTypes][VP] Add splitting support for vp.gather and vp.scatter.
Thu, Jan 20, 2:08 AM · Restricted Project
victor-eds committed rGc10c74887875: [LegalizeTypes][VP] Add widening support for vp.gather and vp.scatter (authored by victor-eds).
[LegalizeTypes][VP] Add widening support for vp.gather and vp.scatter
Thu, Jan 20, 12:58 AM
victor-eds closed D117557: [LegalizeTypes][VP] Add widening support for vp.gather and vp.scatter.
Thu, Jan 20, 12:58 AM · Restricted Project

Wed, Jan 19

victor-eds added reviewers for D117557: [LegalizeTypes][VP] Add widening support for vp.gather and vp.scatter: frasercrmck, simoll, rogfer01, craig.topper, RKSimon.
Wed, Jan 19, 7:10 AM · Restricted Project

Tue, Jan 18

victor-eds requested review of D117557: [LegalizeTypes][VP] Add widening support for vp.gather and vp.scatter.
Tue, Jan 18, 5:16 AM · Restricted Project
victor-eds committed rGb7bf96a25865: [LegalizeTypes][VP] Add widening support for vp.reduce.* (authored by victor-eds).
[LegalizeTypes][VP] Add widening support for vp.reduce.*
Tue, Jan 18, 2:21 AM
victor-eds closed D117467: [LegalizeTypes][VP] Add widening support for vp.reduce.*.
Tue, Jan 18, 2:21 AM · Restricted Project
victor-eds updated the diff for D117467: [LegalizeTypes][VP] Add widening support for vp.reduce.*.

Update tests

Tue, Jan 18, 2:20 AM · Restricted Project
victor-eds committed rGfd1dce35bd59: [LegalizeTypes][VP] Add splitting support for vp.reduction.* (authored by victor-eds).
[LegalizeTypes][VP] Add splitting support for vp.reduction.*
Tue, Jan 18, 1:30 AM
victor-eds closed D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*.
Tue, Jan 18, 1:30 AM · Restricted Project
victor-eds updated the diff for D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*.

Add assertions in new function

Tue, Jan 18, 12:40 AM · Restricted Project

Mon, Jan 17

victor-eds updated the diff for D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*.

Update tests

Mon, Jan 17, 10:01 AM · Restricted Project
victor-eds added a comment to D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*.

Done

Mon, Jan 17, 9:37 AM · Restricted Project
victor-eds updated the diff for D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*.

Copy SDValue instead of passing reference

Mon, Jan 17, 9:37 AM · Restricted Project
victor-eds updated the diff for D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*.

Fixing sequential FP reduction issues

Mon, Jan 17, 9:34 AM · Restricted Project
victor-eds added reviewers for D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*: frasercrmck, simoll, rogfer01, craig.topper, RKSimon.
Mon, Jan 17, 8:01 AM · Restricted Project
victor-eds added reviewers for D117467: [LegalizeTypes][VP] Add widening support for vp.reduce.*: frasercrmck, craig.topper, rogfer01, simoll, RKSimon.
Mon, Jan 17, 7:47 AM · Restricted Project
victor-eds requested review of D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*.
Mon, Jan 17, 5:47 AM · Restricted Project
victor-eds requested review of D117467: [LegalizeTypes][VP] Add widening support for vp.reduce.*.
Mon, Jan 17, 4:26 AM · Restricted Project

Fri, Jan 7

victor-eds committed rG38efa68b083e: [LegalizeTypes][VP] Add splitting support for vp.select (authored by victor-eds).
[LegalizeTypes][VP] Add splitting support for vp.select
Fri, Jan 7, 12:46 AM
victor-eds closed D116651: [LegalizeTypes][VP] Add splitting support for vp.select.
Fri, Jan 7, 12:46 AM · Restricted Project

Thu, Jan 6

victor-eds added a comment to D116651: [LegalizeTypes][VP] Add splitting support for vp.select.

Done

Thu, Jan 6, 12:11 AM · Restricted Project
victor-eds updated the diff for D116651: [LegalizeTypes][VP] Add splitting support for vp.select.

Test

Thu, Jan 6, 12:10 AM · Restricted Project
victor-eds updated the diff for D116651: [LegalizeTypes][VP] Add splitting support for vp.select.

Revert formatting

Thu, Jan 6, 12:09 AM · Restricted Project

Wed, Jan 5

victor-eds updated the diff for D116651: [LegalizeTypes][VP] Add splitting support for vp.select.

Update floating point tests

Wed, Jan 5, 4:55 AM · Restricted Project
victor-eds updated the diff for D116651: [LegalizeTypes][VP] Add splitting support for vp.select.

Add floating point tests

Wed, Jan 5, 4:48 AM · Restricted Project
victor-eds added reviewers for D116651: [LegalizeTypes][VP] Add splitting support for vp.select: frasercrmck, craig.topper, rogfer01, simoll, RKSimon.
Wed, Jan 5, 4:24 AM · Restricted Project
victor-eds requested review of D116651: [LegalizeTypes][VP] Add splitting support for vp.select.
Wed, Jan 5, 4:21 AM · Restricted Project
victor-eds committed rG96e220e68868: [LegalizeTypes][VP] Add integer promotion support for vp.select (authored by victor-eds).
[LegalizeTypes][VP] Add integer promotion support for vp.select
Wed, Jan 5, 3:02 AM
victor-eds closed D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.
Wed, Jan 5, 3:02 AM · Restricted Project
victor-eds committed rGdf5226dfb33d: [LegalizeTypes][VP] Add widening support for vp.select (authored by victor-eds).
[LegalizeTypes][VP] Add widening support for vp.select
Wed, Jan 5, 1:22 AM
victor-eds closed D116407: [LegalizeTypes][VP] Add widening support for vp.select.
Wed, Jan 5, 1:22 AM · Restricted Project

Tue, Jan 4

victor-eds added a comment to D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Done

Tue, Jan 4, 1:37 AM · Restricted Project
victor-eds updated the diff for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Drop boolean argument

Tue, Jan 4, 1:36 AM · Restricted Project
victor-eds added a comment to D116407: [LegalizeTypes][VP] Add widening support for vp.select.

Done

Tue, Jan 4, 1:09 AM · Restricted Project
victor-eds updated the diff for D116407: [LegalizeTypes][VP] Add widening support for vp.select.

Drop boolean argument and rename function

Tue, Jan 4, 1:07 AM · Restricted Project

Mon, Jan 3

victor-eds updated the diff for D116407: [LegalizeTypes][VP] Add widening support for vp.select.

Move new tests

Mon, Jan 3, 4:09 AM · Restricted Project

Fri, Dec 31

victor-eds added a comment to D115546: [RISCV][VP] Add RVV codegen for [nX]vXi1 vp.select.

@craig.topper Can you please land this one for me? I tried to fix the pipeline by rebasing (hence the last diff), but it appears to be broken in main. I'll ask for commit access after this patch has been landed so that I don't need to ask you for it again. Thanks!

Fri, Dec 31, 3:07 AM · Restricted Project

Thu, Dec 30

victor-eds updated the diff for D116407: [LegalizeTypes][VP] Add widening support for vp.select.

Apply format changes

Thu, Dec 30, 7:40 AM · Restricted Project
victor-eds updated the diff for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Apply format changes

Thu, Dec 30, 7:36 AM · Restricted Project
victor-eds added reviewers for D116407: [LegalizeTypes][VP] Add widening support for vp.select: frasercrmck, craig.topper, RKSimon, rogfer01.
Thu, Dec 30, 5:26 AM · Restricted Project
victor-eds updated the diff for D115546: [RISCV][VP] Add RVV codegen for [nX]vXi1 vp.select.

Rebase

Thu, Dec 30, 5:24 AM · Restricted Project
victor-eds updated the diff for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Change commit message

Thu, Dec 30, 5:22 AM · Restricted Project
victor-eds updated the diff for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Change commit message

Thu, Dec 30, 5:20 AM · Restricted Project
victor-eds requested review of D116407: [LegalizeTypes][VP] Add widening support for vp.select.
Thu, Dec 30, 5:18 AM · Restricted Project
victor-eds updated the diff for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Add comments for boolean arguments

Thu, Dec 30, 4:57 AM · Restricted Project
victor-eds abandoned D116402: [LegalizeTypes][VP] Add integer promotion support for vp_select.
Thu, Dec 30, 4:49 AM · Restricted Project
victor-eds requested review of D116402: [LegalizeTypes][VP] Add integer promotion support for vp_select.
Thu, Dec 30, 4:49 AM · Restricted Project
victor-eds abandoned D116401: [LegalizeTypes][VP] Add integer promotion support for vp_select.
Thu, Dec 30, 4:47 AM · Restricted Project
victor-eds requested review of D116401: [LegalizeTypes][VP] Add integer promotion support for vp_select.
Thu, Dec 30, 4:47 AM · Restricted Project
victor-eds updated the diff for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Change indentation

Thu, Dec 30, 4:29 AM · Restricted Project
victor-eds added reviewers for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select: frasercrmck, craig.topper, rogfer01, RKSimon.
Thu, Dec 30, 4:26 AM · Restricted Project
victor-eds updated the diff for D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.

Call getSelect instead of getNode

Thu, Dec 30, 4:24 AM · Restricted Project
victor-eds requested review of D116400: [LegalizeTypes][VP] Add integer promotion support for vp.select.
Thu, Dec 30, 4:18 AM · Restricted Project

Dec 23 2021

victor-eds updated the diff for D115546: [RISCV][VP] Add RVV codegen for [nX]vXi1 vp.select.

Unroll op if the operands are not i1 vectors

Dec 23 2021, 12:30 AM · Restricted Project

Dec 18 2021

victor-eds added a comment to D115339: [RISCV][VP] Lower mask vector VP AND/OR/XOR to RVV instructions.

Thanks. I don't have permissions to merge on main yet, so I need someone to land this patch for me now that it's been accepted. @craig.topper

Dec 18 2021, 3:27 AM · Restricted Project

Dec 14 2021

victor-eds edited reviewers for D115339: [RISCV][VP] Lower mask vector VP AND/OR/XOR to RVV instructions, added: rogfer01; removed: efocht.
Dec 14 2021, 12:32 AM · Restricted Project
victor-eds edited reviewers for D115546: [RISCV][VP] Add RVV codegen for [nX]vXi1 vp.select, added: rogfer01; removed: efocht.
Dec 14 2021, 12:31 AM · Restricted Project

Dec 10 2021

victor-eds added reviewers for D115546: [RISCV][VP] Add RVV codegen for [nX]vXi1 vp.select: frasercrmck, efocht, craig.topper.
Dec 10 2021, 11:50 AM · Restricted Project
victor-eds requested review of D115546: [RISCV][VP] Add RVV codegen for [nX]vXi1 vp.select.
Dec 10 2021, 11:42 AM · Restricted Project
victor-eds updated the diff for D115339: [RISCV][VP] Lower mask vector VP AND/OR/XOR to RVV instructions.

Format file

Dec 10 2021, 10:25 AM · Restricted Project

Dec 8 2021

victor-eds added reviewers for D115339: [RISCV][VP] Lower mask vector VP AND/OR/XOR to RVV instructions: frasercrmck, efocht, craig.topper.
Dec 8 2021, 6:18 AM · Restricted Project
victor-eds requested review of D115339: [RISCV][VP] Lower mask vector VP AND/OR/XOR to RVV instructions.
Dec 8 2021, 6:15 AM · Restricted Project

Nov 26 2021

victor-eds added reviewers for D114629: [RISCV][VP] Add RVV codegen for vp.select: craig.topper, simoll, rogfer01, frasercrmck.
Nov 26 2021, 4:15 AM · Restricted Project
victor-eds updated the diff for D114629: [RISCV][VP] Add RVV codegen for vp.select.

Test

Nov 26 2021, 4:14 AM · Restricted Project
victor-eds requested review of D114629: [RISCV][VP] Add RVV codegen for vp.select.
Nov 26 2021, 4:11 AM · Restricted Project