Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D147033

[WebAssembly] Select call_indirect for alloca calls
ClosedPublic
Actions

Authored by aheejin on Mar 28 2023, 1:08 AM.

Details

Reviewers
tlively
HerrCai0907
Commits
rGd91c9aef9b37: [WebAssembly] Select call_indirect for alloca calls
Summary

Currently calling stack locations is selected using CALL in ISel,
resulting in an invalid code and crashing in AsmPrinter. FastISel
correctly selects it will CALL_INDIRECT.

Fixes the problem reported in D146781.

Diff Detail

Event Timeline

aheejin created this revision.Mar 28 2023, 1:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 1:08 AM
Herald added subscribers: pmatos, asb, wingo and 6 others. · View Herald Transcript
aheejin requested review of this revision.Mar 28 2023, 1:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 1:08 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
aheejin mentioned this in D146781: [Webassembly] consider invalid CALL_S in removeRegisterOperands.Mar 28 2023, 1:08 AM
Harbormaster completed remote builds in B222183: Diff 508924.Mar 28 2023, 2:06 AM
HerrCai0907 added a comment.Mar 28 2023, 6:41 AM

what about isGlobal, just like #60003 mentioned?

tlively accepted this revision.Mar 28 2023, 7:25 AM

LGTM!

This revision is now accepted and ready to land.Mar 28 2023, 7:25 AM
aheejin added a comment.Mar 28 2023, 8:08 PM
In D147033#4227331, @HerrCai0907 wrote:

what about isGlobal, just like #60003 mentioned?

I took a look at this, and this seems to be a different problem, which can be fixed separately.

HerrCai0907 accepted this revision.Mar 29 2023, 3:56 AM

so LGTM

This revision was landed with ongoing or failed builds.Mar 29 2023, 12:47 PM
Closed by commit rGd91c9aef9b37: [WebAssembly] Select call_indirect for alloca calls (authored by aheejin). · Explain Why
This revision was automatically updated to reflect the committed changes.
aheejin added a commit: rGd91c9aef9b37: [WebAssembly] Select call_indirect for alloca calls.
aheejin mentioned this in D147396: [WebAssembly] Move call_indirect_alloca to call.ll.Apr 1 2023, 9:15 PM
aheejin added a comment.Apr 4 2023, 4:23 PM
In D147033#4227331, @HerrCai0907 wrote:

what about isGlobal, just like #60003 mentioned?

The attempted fix for this is in D147397.

aheejin mentioned this in rG47fc0186e630: [WebAssembly] Move call_indirect_alloca to call.ll.Apr 5 2023, 1:42 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
WebAssembly/
5 lines
test/
CodeGen/
WebAssembly/
21 lines

Diff 509445

View Options

llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

Loading...
View Options

llvm/test/CodeGen/WebAssembly/call-indirect.ll

Loading...