[WebAssembly] Select call_indirect for alloca calls

[aheejin]

Summary

Currently calling stack locations is selected using CALL in ISel,
resulting in an invalid code and crashing in AsmPrinter. FastISel
correctly selects it will CALL_INDIRECT.

Fixes the problem reported in D146781.

[HerrCai0907]

what about isGlobal, just like #60003 mentioned?

[tlively]

LGTM!

[aheejin]

In D147033#4227331, @HerrCai0907 wrote:

what about isGlobal, just like #60003 mentioned?

I took a look at this, and this seems to be a different problem, which can be fixed separately.

[HerrCai0907]

so LGTM

[aheejin]

In D147033#4227331, @HerrCai0907 wrote:

what about isGlobal, just like #60003 mentioned?

The attempted fix for this is in D147397.

llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp

 LowerCallResults(MachineInstr &CallResults, DebugLoc DL, MachineBasicBlock *BB,
                  const WebAssemblySubtarget *Subtarget,
                  const TargetInstrInfo &TII) {
   MachineInstr &CallParams = *CallResults.getPrevNode();
   assert(CallParams.getOpcode() == WebAssembly::CALL_PARAMS);
   assert(CallResults.getOpcode() == WebAssembly::CALL_RESULTS ||
          CallResults.getOpcode() == WebAssembly::RET_CALL_RESULTS);
 
-  bool IsIndirect = CallParams.getOperand(0).isReg();
+  bool IsIndirect =
+      CallParams.getOperand(0).isReg() || CallParams.getOperand(0).isFI();
   bool IsRetCall = CallResults.getOpcode() == WebAssembly::RET_CALL_RESULTS;
 
   bool IsFuncrefCall = false;
-  if (IsIndirect) {
+  if (IsIndirect && CallParams.getOperand(0).isReg()) {
     Register Reg = CallParams.getOperand(0).getReg();
     const MachineFunction *MF = BB->getParent();
     const MachineRegisterInfo &MRI = MF->getRegInfo();
     const TargetRegisterClass *TRC = MRI.getRegClass(Reg);
     IsFuncrefCall = (TRC == &WebAssembly::FUNCREFRegClass);
     assert(!IsFuncrefCall || Subtarget->hasReferenceTypes());
   }
 

llvm/test/CodeGen/WebAssembly/call-indirect.ll

 ; REF:        call_indirect __indirect_function_table, () -> ()
 ; NOREF:      call_indirect () -> ()
 ; CHECK-NEXT: end_function
 define void @call_indirect_void(ptr %callee) {
   call void %callee()
   ret void
 }
 
+; CHECK-LABEL: call_indirect_alloca:
+; CHECK-NEXT: .functype call_indirect_alloca () -> ()
+; CHECK:      local.tee  0
+; CHECK-NEXT: global.set  __stack_pointer
+; CHECK-NEXT: local.get  0
+; CHECK-NEXT: i32.const  12
+; CHECK-NEXT: i32.add
+; REF:        call_indirect __indirect_function_table, () -> ()
+; NOREF:      call_indirect () -> ()
+define void @call_indirect_alloca() {
+entry:
+  %ptr = alloca i32, align 4
+  call void %ptr()
+  ret void
+}
+
 ; OBJ:    Imports:
 ; OBJ-NEXT:      - Module:          env
 ; OBJ-NEXT:        Field:           __linear_memory
 ; OBJ-NEXT:        Kind:            MEMORY
 ; OBJ-NEXT:        Memory:
 ; OBJ-NEXT:          Minimum:         0x0
 ; OBJ-NEXT:      - Module:          env
+; OBJ-NEXT:        Field:           __stack_pointer
+; OBJ-NEXT:        Kind:            GLOBAL
+; OBJ-NEXT:        GlobalType:      I32
+; OBJ-NEXT:        GlobalMutable:   true
+; OBJ-NEXT:      - Module:          env
 ; OBJ-NEXT:        Field:           __indirect_function_table
 ; OBJ-NEXT:        Kind:            TABLE