Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[WebAssembly] Move call_indirect_alloca to call.ll
ClosedPublic

Authored by aheejin on Apr 1 2023, 9:15 PM.

Details

Summary

Not sure the distinction between call.ll and call-indirect.ll,
because call.ll also seems to contain many call_indirect tests. Also
before D147033 call-indirect.ll only contained a single test and it
also tests it with obj2yaml, so I guess that file was created for
testing functionalities for object files as well.

We can probably merge these two someday. But anyway, this moves
call_indirect_alloca I added in D147033 to call.ll, given that that
file contains more call_indirect tests and I'm planning to add more
call_indirect tests in a followup CL.

Diff Detail

Event Timeline

aheejin created this revision.Apr 1 2023, 9:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2023, 9:15 PM
Herald added subscribers: pmatos, asb, wingo and 5 others. · View Herald Transcript
aheejin requested review of this revision.Apr 1 2023, 9:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 1 2023, 9:15 PM
tlively accepted this revision.Apr 3 2023, 7:42 AM
This revision is now accepted and ready to land.Apr 3 2023, 7:42 AM
This revision was automatically updated to reflect the committed changes.