Paths

Table of Contentst

Differential D146972

[mlir][IR][NFC] Move CastOpInterface helpers to mlir/Interfaces
Needs ReviewPublic
Actions

Authored by springerm on Mar 27 2023, 8:06 AM.

Tags

Subscribers

View All 26 Subscribers

Details

Reviewers

rriddle
mehdi_amini
jpienaar
nicolasvasilache
kuhar

Summary

These helpers should not be part of the IR build unit.

The interface is now implemented on builtin.unrealized_conversion_cast with an external model.

Also rename the CastOpInterfaces Bazel target name to CastInterfaces to be consistent with the CMake target name.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

springerm created this revision.Mar 27 2023, 8:06 AM

Herald added a reviewer: jpienaar. · View Herald TranscriptMar 27 2023, 8:06 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 20 others. · View Herald Transcript

springerm requested review of this revision.Mar 27 2023, 8:06 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 27 2023, 8:06 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B222027: Diff 508668.Mar 27 2023, 9:15 AM

rebase

Herald added a reviewer: kuhar. · View Herald TranscriptThu, Jun 1, 4:47 AM

Herald added a subscriber: bviyer. · View Herald Transcript

springerm edited the summary of this revision. (Show Details)Thu, Jun 1, 4:47 AM

Harbormaster completed remote builds in B235800: Diff 527364.Thu, Jun 1, 5:08 AM

nicolasvasilache accepted this revision.Thu, Jun 1, 6:10 AM

springerm edited the summary of this revision. (Show Details)Thu, Jun 1, 6:46 AM

springerm mentioned this in D151888: [mlir][transform] Utilize op interface instead of tensor::TrackingLister.Thu, Jun 1, 6:58 AM

springerm added a child revision: D151888: [mlir][transform] Utilize op interface instead of tensor::TrackingLister.Thu, Jun 1, 6:58 AM

springerm added inline comments.Thu, Jun 1, 7:03 AM

mlir/include/mlir/Interfaces/CastInterfaces.h
31	Note: This registers the `unrealized_conversion_cast` external model. Such functions are usually located in the build target of the respective dialect, but there is no separate build target for the "builtin" dialect.

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

Dialect/

EmitC/

IR/

1 line

Shape/

IR/

1 line

IR/

1 line

3 lines

15 lines

InitAllDialects.h

2 lines

Interfaces/

CastInterfaces.h

15 lines

CastInterfaces.td

2 lines

lib/

Dialect/

Arith/

IR/

1 line

Transform/

IR/

1 line

IR/

BuiltinDialect.cpp

10 lines

46 lines

Interfaces/

CastInterfaces.cpp

74 lines

test/

lib/

Tools/

PDLL/

1 line

1 line

tools/

mlir-opt/

1 line

utils/

bazel/

llvm-project-overlay/

mlir/

19 lines

examples/

toy/

Ch4/

2 lines

Ch5/

2 lines

Ch6/

2 lines

Ch7/

2 lines

test/

1 line

Diff 527364

mlir/include/mlir/Dialect/EmitC/IR/EmitC.h

Loading...

mlir/include/mlir/Dialect/Shape/IR/Shape.h

Loading...

mlir/include/mlir/IR/BuiltinOps.h

Loading...

mlir/include/mlir/IR/BuiltinOps.td

Loading...

mlir/include/mlir/IR/OpDefinition.h

Loading...

mlir/include/mlir/InitAllDialects.h

Loading...

mlir/include/mlir/Interfaces/CastInterfaces.h

Loading...

mlir/include/mlir/Interfaces/CastInterfaces.td

Loading...

mlir/lib/Dialect/Arith/IR/CMakeLists.txt

Loading...

mlir/lib/Dialect/Transform/IR/CMakeLists.txt

Loading...

mlir/lib/IR/BuiltinDialect.cpp

Loading...

mlir/lib/IR/Operation.cpp

Loading...

mlir/lib/Interfaces/CastInterfaces.cpp

Loading...

mlir/test/lib/Tools/PDLL/CMakeLists.txt

Loading...

mlir/test/lib/Tools/PDLL/TestPDLL.cpp

Loading...

mlir/tools/mlir-opt/CMakeLists.txt

Loading...

utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

Loading...

utils/bazel/llvm-project-overlay/mlir/examples/toy/Ch4/BUILD.bazel

Loading...

utils/bazel/llvm-project-overlay/mlir/examples/toy/Ch5/BUILD.bazel

Loading...

utils/bazel/llvm-project-overlay/mlir/examples/toy/Ch6/BUILD.bazel

Loading...

utils/bazel/llvm-project-overlay/mlir/examples/toy/Ch7/BUILD.bazel

Loading...

utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel

Loading...