This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Presburger] Fix swap not swapping identifiers in IntegerRelation
AcceptedPublic

Authored by Groverkss on Mar 26 2023, 5:19 AM.

Reviewers

Summary

This patch fixes a bug where identifiers were not swapped when doing a swap
in IntegerRelation

Groverkss requested review of this revision.Mar 26 2023, 5:19 AM

Can you mention the method name in the title and/or description?

This revision is now accepted and ready to land.May 12 2023, 6:00 AM

Also, why is this dependent on another patch?

mlir/lib/Analysis/Presburger/IntegerRelation.cpp
381	A test case that exercises this?

Path

Size

mlir/

lib/

Analysis/

Presburger/

6 lines

	Show First 20 Lines • Show All 368 Lines • ▼ Show 20 Lines

	void IntegerRelation::swapVar(unsigned posA, unsigned posB) {			void IntegerRelation::swapVar(unsigned posA, unsigned posB) {
	assert(posA < getNumVars() && "invalid position A");			assert(posA < getNumVars() && "invalid position A");
	assert(posB < getNumVars() && "invalid position B");			assert(posB < getNumVars() && "invalid position B");

	if (posA == posB)			if (posA == posB)
	return;			return;

				VarKind kindA = space.getVarKindAt(posA);
				VarKind kindB = space.getVarKindAt(posB);
				unsigned relativePosA = posA - getVarKindOffset(kindA);
				unsigned relativePosB = posB - getVarKindOffset(kindB);
				space.swapVar(kindA, kindB, relativePosA, relativePosB);
				bondhugulaUnsubmitted Not Done Reply Inline Actions A test case that exercises this? bondhugula: A test case that exercises this?

	inequalities.swapColumns(posA, posB);			inequalities.swapColumns(posA, posB);
	equalities.swapColumns(posA, posB);			equalities.swapColumns(posA, posB);
	}			}

	void IntegerRelation::clearConstraints() {			void IntegerRelation::clearConstraints() {
	equalities.resizeVertically(0);			equalities.resizeVertically(0);
	inequalities.resizeVertically(0);			inequalities.resizeVertically(0);
	}			}
	▲ Show 20 Lines • Show All 1,896 Lines • Show Last 20 Lines