Adding debug log when clean empty namespace can make #60051 more cleaner.
User will not be confused why the whole namespace is deleted after fixing modernize-concat-nested-namespaces.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This shouldn't be delivered. Do such tests, locally, instead of committing them.
This change impact clang, and all tools, not only clang-tidy, therfor [clang-tidy] prefix is misleading.
Issue related to modernize-concat-nested-namespaces should be fixed by clang-tidy itself.
It's visible in AST, so clang-tidy could fix it.
TranslationUnitDecl `-NamespaceDecl <line:1:1, line:3:1> line:1:11 a `-NamespaceDecl <line:2:1, col:14> col:11 b
For me this change should be abandoned.
And proper way of informing users would be to emit warning with that information from clang-tidy, not by adding some debug logs to code.