This is an archive of the discontinued LLVM Phabricator instance.

[dsymutil] Add the ability to generate universal binaries with a fat64 header
ClosedPublic

Authored by JDevlieghere on Mar 25 2023, 10:41 AM.

Details

Summary

Add the ability to generate universal binaries with a fat64 header.

rdar://107223939

Diff Detail

Event Timeline

JDevlieghere created this revision.Mar 25 2023, 10:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 10:41 AM
JDevlieghere requested review of this revision.Mar 25 2023, 10:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 10:41 AM

Limit test to Darwin as it relies on lipo

pete accepted this revision.Mar 26 2023, 10:24 AM

LGTM

This revision is now accepted and ready to land.Mar 26 2023, 10:24 AM

I understand that auto-detection can be a double-edged sword, but — should this be autodetected based on the input size? Or this impossible because we only know the sizer after it's too late?

llvm/tools/dsymutil/dsymutil.cpp
787

typo: create

I understand that auto-detection can be a double-edged sword, but — should this be autodetected based on the input size? Or this impossible because we only know the sizer after it's too late?

Given that the tooling support isn't quite there yet, I think this should be opt-in, but I don't mind making this the default if the output size will exceed 4GB in the future.