This is an archive of the discontinued LLVM Phabricator instance.

[mlir][Interfaces] ValueBoundsOpInterface: Support IntegerTypes
Needs ReviewPublic

Authored by springerm on Mar 25 2023, 4:35 AM.



Both IndexType and IntegerTypes are now supported. This is needed to compute bounds for condition values of and scf.if.

Depends On: D143910

Diff Detail

Event Timeline

springerm created this revision.Mar 25 2023, 4:35 AM
Herald added a project: Restricted Project. · View Herald Transcript
springerm requested review of this revision.Mar 25 2023, 4:35 AM
dcaballe added inline comments.Apr 6 2023, 4:51 PM

To void this complexity, could the user just get the default type and convert it at their wish?


Ok, some of my questions in previous commits are answered now :)

dcaballe added inline comments.Apr 26 2023, 11:10 PM

Sorry if I'm missing something trivial but I'm still not convinced that this conversion should be part of the reify logic. Couldn't we just reify the value using the default type and let the conversion to the user?