This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Remove unnecceary OMPT flag from builder factory
ClosedPublic

Authored by jplehr on Mar 23 2023, 2:38 AM.

Details

Summary

The OMPT option defaults to "ON" in the OpenMP project CMake. To remove
potential confusion whether OMPT support is enabled in a buildbot,
remove this argument. It was only able to *enable* OMPT support and is
now useless.

If OMPT support should be disabled in a buildbot, this should be made
explicit via the additional CMake flag.

Diff Detail

Event Timeline

jplehr created this revision.Mar 23 2023, 2:38 AM
jplehr requested review of this revision.Mar 23 2023, 2:38 AM
jdoerfert accepted this revision.Mar 23 2023, 9:29 AM

I think the conclusion was we don't want this.

This revision is now accepted and ready to land.Mar 23 2023, 9:29 AM
jplehr updated this revision to Diff 507999.Mar 24 2023, 1:58 AM

Rebase and ready to land