The default behavior of getProjectedMap may be surprising as it implicitly compresses the dims and
the unused symbols.
Make these explicit in the API and refactor to more idiomatic implementations with better reuse.
Paths
| Differential D146611
[mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and projectSymbols ClosedPublic Authored by nicolasvasilache on Mar 22 2023, 2:22 AM.
Details Summary The default behavior of getProjectedMap may be surprising as it implicitly compresses the dims and Make these explicit in the API and refactor to more idiomatic implementations with better reuse.
Diff Detail
Event Timeline
This revision is now accepted and ready to land.Mar 22 2023, 2:59 AM ftynse added inline comments.
nicolasvasilache added inline comments.
This revision was landed with ongoing or failed builds.Mar 22 2023, 5:31 AM Closed by commit rG255ba1c334b8: [mlir][AffineMap] NFC - Refactor getProjectedMap and split into projectDims and… (authored by nicolasvasilache). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 507325 mlir/include/mlir/IR/AffineMap.h
mlir/lib/IR/AffineMap.cpp
|
Was there a typo in the original comment: not listed -> listed?