This is an archive of the discontinued LLVM Phabricator instance.

Add tests from gfortran test-suite [Patch 1 of 6]
AbandonedPublic

Authored by tarunprabhu on Mar 20 2023, 5:12 PM.

Details

Summary

Add Fortran tests from GCC's test suite. This is the first of six patches that add the test files. A separate patch adds the build files. All the patches will be committed together

  1. https://reviews.llvm.org/D146475 (this patch)
  2. https://reviews.llvm.org/D146477
  3. https://reviews.llvm.org/D146478
  4. https://reviews.llvm.org/D146479
  5. https://reviews.llvm.org/D146480
  6. https://reviews.llvm.org/D146481

A discourse post discussing this is here.

Diff Detail

Repository
rT test-suite

Event Timeline

tarunprabhu created this revision.Mar 20 2023, 5:12 PM
tarunprabhu created this object with visibility "No One".
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 5:12 PM
tarunprabhu requested review of this revision.Mar 20 2023, 5:12 PM
tarunprabhu edited the summary of this revision. (Show Details)
tarunprabhu edited the summary of this revision. (Show Details)Mar 20 2023, 5:36 PM
tarunprabhu edited the summary of this revision. (Show Details)Mar 20 2023, 6:19 PM
tarunprabhu changed the visibility from "No One" to "Public (No Login Required)".
tarunprabhu added a subscriber: flang-commits.
tarunprabhu edited the summary of this revision. (Show Details)Mar 20 2023, 6:21 PM

Who owns the copyright to these files, and does their license permit you to copy them into this repository with its license?

How with changes made to the original files in the future make their way to this copy?

Could you instead create a script that rsyncs these tests to a local cache and runs f18 against them from there?

Who owns the copyright to these files, and does their license permit you to copy them into this repository with its license?

The files are from GCC's testsuite. To the best of my knowledge, they are licensed under GPL/GPLv3 which allows us to copy them into this repository with that license. The license files are included in a separate patch which will be committed together with this one.

@lenary did something similar with GCC's C torture tests. Per his comment, we do not want to make any changes to the files themselves, so simply importing them with the correct license should mean that we are in compliance.

How with changes made to the original files in the future make their way to this copy?

As I understand it, any changes would have to be brought over manually. I don't know if there is some automation somewhere that periodically pulls in changes.

Could you instead create a script that rsyncs these tests to a local cache and runs f18 against them from there?

That is a possibility. The same issue was raised when adding the C torture tests. At the time, there was more inclination towards importing the tests which is why I did the same here.

tarunprabhu abandoned this revision.Mar 31 2023, 8:01 AM

Based on discussions here, the test files will be committed after the patch containing the build and license files.