This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Add hex comments to mov-imm spellings in the InstPrinter
ClosedPublic

Authored by jroelofs on Mar 14 2023, 5:11 PM.

Diff Detail

Event Timeline

jroelofs created this revision.Mar 14 2023, 5:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 5:11 PM
jroelofs requested review of this revision.Mar 14 2023, 5:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 5:11 PM
jroelofs added inline comments.Mar 14 2023, 5:17 PM
llvm/test/CodeGen/AArch64/movw-consts.ll
157

Would it be better if the comment's bitwidth matched the register's bitwidth?

paquette added inline comments.Mar 14 2023, 10:44 PM
llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
304

static_cast is more greppable

jroelofs updated this revision to Diff 505494.Mar 15 2023, 8:09 AM
jroelofs marked an inline comment as done.
Gerolf added a subscriber: Gerolf.Mar 15 2023, 9:47 AM

The cases you changed *LGTM* (really good to me!! :-)) I did not check that all cases are covered, but this shouldn't hold up the merge.

This revision is now accepted and ready to land.Mar 15 2023, 10:42 AM
paquette added inline comments.Mar 15 2023, 10:43 AM
llvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
303

this could be factored out into a function?

jroelofs updated this revision to Diff 505598.Mar 15 2023, 1:01 PM
jroelofs marked an inline comment as done.
This revision was landed with ongoing or failed builds.Mar 15 2023, 2:09 PM
This revision was automatically updated to reflect the committed changes.