Page MenuHomePhabricator
Differential D146064

[SimplifyLibCalls] Return Value from optimizeSinCosPi when making change
ClosedPublic
Actions

Authored by aeubanks on Mar 14 2023, 9:44 AM.

Details

Reviewers
spatel
nikic
Commits
rG093b2640ea90: [SimplifyLibCalls] Return Value from optimizeSinCosPi when making change
Summary

Or else InstCombine can incorrectly report that no change has been made.

This optimization doesn't really fit into InstCombine since it optimizes multiple instructions at once; there's likely a more comprehensive fix.

Diff Detail

Event Timeline

aeubanks created this revision.Mar 14 2023, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 9:44 AM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
aeubanks requested review of this revision.Mar 14 2023, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2023, 9:44 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B219387: Diff 505144.Mar 14 2023, 11:15 AM
nikic accepted this revision.Mar 14 2023, 2:28 PM

LGTM

This revision is now accepted and ready to land.Mar 14 2023, 2:28 PM
This revision was landed with ongoing or failed builds.Mar 14 2023, 3:17 PM
Closed by commit rG093b2640ea90: [SimplifyLibCalls] Return Value from optimizeSinCosPi when making change (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG093b2640ea90: [SimplifyLibCalls] Return Value from optimizeSinCosPi when making change.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Transforms/
Utils/
2 lines
lib/
Transforms/
Utils/
7 lines
test/
Transforms/
InstCombine/
14 lines

Diff 505296

View Options

llvm/include/llvm/Transforms/Utils/SimplifyLibCalls.h

Loading...
View Options

llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp

Loading...
View Options

llvm/test/Transforms/InstCombine/sincospi.ll

Loading...