Or else InstCombine can incorrectly report that no change has been made.
This optimization doesn't really fit into InstCombine since it optimizes multiple instructions at once; there's likely a more comprehensive fix.
Paths
| Differential D146064
[SimplifyLibCalls] Return Value from optimizeSinCosPi when making change ClosedPublic Authored by aeubanks on Mar 14 2023, 9:44 AM.
Details Summary Or else InstCombine can incorrectly report that no change has been made. This optimization doesn't really fit into InstCombine since it optimizes multiple instructions at once; there's likely a more comprehensive fix.
Diff Detail
Event TimelineThis revision is now accepted and ready to land.Mar 14 2023, 2:28 PM This revision was landed with ongoing or failed builds.Mar 14 2023, 3:17 PM Closed by commit rG093b2640ea90: [SimplifyLibCalls] Return Value from optimizeSinCosPi when making change (authored by aeubanks). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 505296 llvm/include/llvm/Transforms/Utils/SimplifyLibCalls.h
llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp
llvm/test/Transforms/InstCombine/sincospi.ll
|