Page MenuHomePhabricator

[SimplifyLibCalls] Return Value from optimizeSinCosPi when making change
ClosedPublic

Authored by aeubanks on Tue, Mar 14, 9:44 AM.

Details

Summary

Or else InstCombine can incorrectly report that no change has been made.

This optimization doesn't really fit into InstCombine since it optimizes multiple instructions at once; there's likely a more comprehensive fix.

Diff Detail

Event Timeline

aeubanks created this revision.Tue, Mar 14, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 9:44 AM
aeubanks requested review of this revision.Tue, Mar 14, 9:44 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 9:44 AM
nikic accepted this revision.Tue, Mar 14, 2:28 PM

LGTM

This revision is now accepted and ready to land.Tue, Mar 14, 2:28 PM
This revision was landed with ongoing or failed builds.Tue, Mar 14, 3:17 PM
This revision was automatically updated to reflect the committed changes.