This is an archive of the discontinued LLVM Phabricator instance.

Differential D145966

[WebAssembly] Replace Bugzilla links with Github issues
ClosedPublic

Authored by aheejin on Mar 13 2023, 10:51 AM.

Details

Reviewers
dschuff
asb
sbc100
Commits
rG4e844a149882: [WebAssembly] Replace Bugzilla links with Github issues

Diff Detail

Unit TestsFailed

TimeTest
60,140 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

aheejin created this revision.Mar 13 2023, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 10:51 AM
Herald added subscribers: pmatos, asb, wingo and 5 others. · View Herald Transcript
aheejin requested review of this revision.Mar 13 2023, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 10:51 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
asb accepted this revision.Mar 13 2023, 10:57 AM

LGTM.

This revision is now accepted and ready to land.Mar 13 2023, 10:57 AM
dschuff accepted this revision.Mar 13 2023, 11:36 AM
Harbormaster completed remote builds in B219103: Diff 504751.Mar 13 2023, 2:40 PM
aheejin updated this revision to Diff 505339.EditedMar 14 2023, 5:42 PM

Replace more bugzilla links in lld

Herald added subscribers: ormris, steven_wu. · View Herald TranscriptMar 14 2023, 5:42 PM
aheejin edited reviewers, added: sbc100; removed: tlively.Mar 14 2023, 5:42 PM
aheejin updated this revision to Diff 505340.Mar 14 2023, 5:47 PM

Replace more bugzilla links in llvm/test

aheejin added inline comments.Mar 14 2023, 5:49 PM
lld/wasm/InputFiles.cpp
444 ↗(On Diff #505340)

@sbc100 This issue seems to be closed. Do we still need this comment?

sbc100 added inline comments.Mar 14 2023, 6:02 PM
lld/wasm/InputFiles.cpp
444 ↗(On Diff #505340)

I think this was added for context, rather than as TODO/FIXME. So I think we can keep it.

Harbormaster completed remote builds in B219527: Diff 505340.Mar 14 2023, 7:43 PM
Closed by commit rG4e844a149882: [WebAssembly] Replace Bugzilla links with Github issues (authored by aheejin). · Explain WhyMar 17 2023, 8:13 PM
This revision was automatically updated to reflect the committed changes.
aheejin added a commit: rG4e844a149882: [WebAssembly] Replace Bugzilla links with Github issues.

Revision Contents

PathSize
llvm/
lib/
Target/
WebAssembly/
2 lines
2 lines

Diff 504751

llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp

Show First 20 Lines • Show All 1,211 Lines • ▼ Show 20 Linesbool WebAssemblyLowerEmscriptenEHSjLj::runEHOnFunction(Function &F) {
// Handle all the landingpad for this function together, as multiple invokes // Handle all the landingpad for this function together, as multiple invokes
// may share a single lp // may share a single lp
for (LandingPadInst *LPI : LandingPads) { for (LandingPadInst *LPI : LandingPads) {
IRB.SetInsertPoint(LPI); IRB.SetInsertPoint(LPI);
SmallVector<Value *, 16> FMCArgs; SmallVector<Value *, 16> FMCArgs;
for (unsigned I = 0, E = LPI->getNumClauses(); I < E; ++I) { for (unsigned I = 0, E = LPI->getNumClauses(); I < E; ++I) {
Constant *Clause = LPI->getClause(I); Constant *Clause = LPI->getClause(I);
// TODO Handle filters (= exception specifications). // TODO Handle filters (= exception specifications).
// https://bugs.llvm.org/show_bug.cgi?id=50396 // https://github.com/llvm/llvm-project/issues/49740
if (LPI->isCatch(I)) if (LPI->isCatch(I))
FMCArgs.push_back(Clause); FMCArgs.push_back(Clause);
} }
// Create a call to __cxa_find_matching_catch_N function // Create a call to __cxa_find_matching_catch_N function
Function *FMCF = getFindMatchingCatch(M, FMCArgs.size()); Function *FMCF = getFindMatchingCatch(M, FMCArgs.size());
CallInst *FMCI = IRB.CreateCall(FMCF, FMCArgs, "fmc"); CallInst *FMCI = IRB.CreateCall(FMCF, FMCArgs, "fmc");
Value *Poison = PoisonValue::get(LPI->getType()); Value *Poison = PoisonValue::get(LPI->getType());
▲ Show 20 Lines • Show All 650 Lines • Show Last 20 Lines

llvm/lib/Target/WebAssembly/WebAssemblyNullifyDebugValueLists.cpp

//=== WebAssemblyNullifyDebugValueLists.cpp - Nullify DBG_VALUE_LISTs ---===// //=== WebAssemblyNullifyDebugValueLists.cpp - Nullify DBG_VALUE_LISTs ---===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
/// ///
/// \file /// \file
/// Nullify DBG_VALUE_LISTs instructions as a temporary measure before we /// Nullify DBG_VALUE_LISTs instructions as a temporary measure before we
/// implement DBG_VALUE_LIST handling in WebAssemblyDebugValueManager. /// implement DBG_VALUE_LIST handling in WebAssemblyDebugValueManager.
/// See https://bugs.llvm.org/show_bug.cgi?id=50361. /// See https://github.com/llvm/llvm-project/issues/49705.
/// TODO Correctly handle DBG_VALUE_LISTs /// TODO Correctly handle DBG_VALUE_LISTs
/// ///
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "WebAssembly.h" #include "WebAssembly.h"
#include "WebAssemblySubtarget.h" #include "WebAssemblySubtarget.h"
#include "llvm/CodeGen/MachineFunctionPass.h" #include "llvm/CodeGen/MachineFunctionPass.h"
using namespace llvm; using namespace llvm;
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines