This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][libomptarget][AMDGPU] Update print launch info
ClosedPublic

Authored by jplehr on Mar 13 2023, 4:50 AM.

Details

Summary

Clean up for the AMD-specific kernel launch info in the NextGen Plugins.

  • Fixes a mistake introduced with the initial commit that added printing of an AMD-only property.
  • Removes another AMD-only property (not clear on upstream status)
  • Adds some more comment to what info is printed.

Diff Detail

Event Timeline

jplehr created this revision.Mar 13 2023, 4:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 4:50 AM
jplehr requested review of this revision.Mar 13 2023, 4:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 4:50 AM
jplehr updated this revision to Diff 505039.Mar 14 2023, 5:00 AM

Updated test and removed two unused variables.

jdoerfert added inline comments.Mar 14 2023, 2:17 PM
openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h
204

Can we assert that there are at most three? Also, add a message to each assert.

jplehr updated this revision to Diff 505276.Mar 14 2023, 2:56 PM

Adds assert and assert messages.
It felt safer to assert exactly three elements to be consistent with the name of the lambda.

jdoerfert accepted this revision.Mar 14 2023, 4:40 PM

LG, one more suggestion

openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp
2648

I would try to shorten this, like # for count, maybe SPGR/VPGR and then <N>/<M>, etc. But this is already better than what we had.

This revision is now accepted and ready to land.Mar 14 2023, 4:40 PM
jplehr updated this revision to Diff 505408.Mar 15 2023, 2:38 AM

Followed Johannes suggestion and rebased

jplehr updated this revision to Diff 505416.Mar 15 2023, 2:56 AM

Actually followed Johannes' suggestion.

This revision was automatically updated to reflect the committed changes.