This is an archive of the discontinued LLVM Phabricator instance.

[mlir][GPUToLLVM] Fix regression introduced with opaque-pointers when generate GPU launch func parameters
ClosedPublic

Authored by zero9178 on Mar 10 2023, 1:52 AM.

Details

Summary

This has caused build failures when enabling opaque pointers for the GPU integration tests as could be seen here:
https://lab.llvm.org/buildbot/#/builders/220/builds/16946 and here https://lab.llvm.org/buildbot/#/builders/61/builds/40822

The gist of the issue was the use of a wrong pointer base type within a GEP. There sadly was no test coverage for either the generating of that GEP, nor is LLVM Dialects GEP verifier currently capable of catching such issues, so it went unnoticed until the integration tests actually attempted to convert it to LLVM IR.

Required to reland https://reviews.llvm.org/D145585

Diff Detail

Event Timeline

zero9178 created this revision.Mar 10 2023, 1:52 AM
zero9178 requested review of this revision.Mar 10 2023, 1:52 AM
zero9178 edited the summary of this revision. (Show Details)Mar 10 2023, 1:52 AM
gysit accepted this revision.Mar 10 2023, 2:03 AM

LGTM!

This revision is now accepted and ready to land.Mar 10 2023, 2:03 AM
This revision was landed with ongoing or failed builds.Mar 10 2023, 2:05 AM
This revision was automatically updated to reflect the committed changes.