Page MenuHomePhabricator
Differential D145507

[LV][VPlan] Fix printing TripCount liveins. NFC
ClosedPublic
Actions

Authored by dmgreen on Tue, Mar 7, 7:32 AM.

Details

Reviewers
fhahn
david-arm
sdesmalen
bmahjour
SjoerdMeijer
Ayal
Commits
rG98481bc723c8: [LV][VPlan] Fix printing TripCount liveins. NFC
Summary

The TripCount liveins would currently be printed as badref in the vplan as they are not allocated slots in the VPSlotTracker. This patch allocates them a slot and adds them to the printed Live-Ins when printing the vplan. It also makes a minor adjustment to printing of Live-ins to reduce the empty lines when multiple Live-ins are present.

Diff Detail

Event Timeline

dmgreen created this revision.Tue, Mar 7, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 7, 7:32 AM
Herald added subscribers: StephenFan, tschuett, psnobl and 3 others. · View Herald Transcript
dmgreen requested review of this revision.Tue, Mar 7, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 7, 7:32 AM
Herald added subscribers: pcwang-thead, vkmr. · View Herald Transcript
Harbormaster completed remote builds in B217878: Diff 503036.Tue, Mar 7, 7:33 AM
sdesmalen accepted this revision.Fri, Mar 10, 8:23 AM

Nice improvement.

This revision is now accepted and ready to land.Fri, Mar 10, 8:23 AM
fhahn accepted this revision.Fri, Mar 10, 12:25 PM

LGTM, thanks!

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-forced.ll
13

It would probably be good to use a variable here, to avoid the test needing updating if the numbering changes.

This revision was landed with ongoing or failed builds.Mon, Mar 13, 12:44 PM
Closed by commit rG98481bc723c8: [LV][VPlan] Fix printing TripCount liveins. NFC (authored by dmgreen). · Explain Why
This revision was automatically updated to reflect the committed changes.
dmgreen added a commit: rG98481bc723c8: [LV][VPlan] Fix printing TripCount liveins. NFC.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
Vectorize/
19 lines
test/
Transforms/
LoopVectorize/
AArch64/
6 lines
6 lines
1 line
11 lines

Diff 504812

View Options

llvm/lib/Transforms/Vectorize/VPlan.cpp

Loading...
View Options

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-forced.ll

Loading...
View Options

llvm/test/Transforms/LoopVectorize/first-order-recurrence-sink-replicate-region.ll

Loading...
View Options

llvm/test/Transforms/LoopVectorize/icmp-uniforms.ll

Loading...
View Options

llvm/test/Transforms/LoopVectorize/vplan-sink-scalars-and-merge.ll

Loading...