This is an archive of the discontinued LLVM Phabricator instance.

[clang][ASTImporter] Import typedefs to distinct records as distinct nodes.
ClosedPublic

Authored by balazske on Mar 7 2023, 12:48 AM.

Details

Summary

When a typedef node is imported, ASTImporter should not find an existing similar
typedef node for it that comes from different context (translation unit or scope).
This should avoid a situation where an existing typedef declaration is returned
at import of a typedef, but the underlying type was already imported as a new
type object.

Diff Detail

Event Timeline

balazske created this revision.Mar 7 2023, 12:48 AM
Herald added a reviewer: shafik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
balazske requested review of this revision.Mar 7 2023, 12:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 12:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vabridgers accepted this revision.Mar 12 2023, 6:51 AM
vabridgers added a reviewer: vabridgers.

LGTM

This revision is now accepted and ready to land.Mar 12 2023, 6:52 AM