This is an archive of the discontinued LLVM Phabricator instance.

Attributor: Start inferring nofpclass
ClosedPublic

Authored by arsenm on Mar 3 2023, 5:07 AM.

Details

Summary

Some of this is boilerplate which doesn't do anything yet.

Diff Detail

Event Timeline

arsenm created this revision.Mar 3 2023, 5:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2023, 5:07 AM
arsenm requested review of this revision.Mar 3 2023, 5:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2023, 5:07 AM
Herald added a subscriber: wdng. · View Herald Transcript
arsenm updated this revision to Diff 502247.Mar 3 2023, 1:33 PM

Rebase on more tests

sameerds accepted this revision.Mar 5 2023, 10:53 PM
This revision is now accepted and ready to land.Mar 5 2023, 10:53 PM
arsenm added inline comments.Mar 6 2023, 5:24 AM
llvm/include/llvm/Transforms/IPO/Attributor.h
4856

Comment copy paste error

jdoerfert accepted this revision.Mar 16 2023, 12:09 PM

LG, assuming we actually don't need the manifest. If we do, we need to see why and what to do about it.

llvm/lib/Transforms/IPO/AttributorAttributes.cpp
10251

We never call manifest for what we assume is dead (https://github.com/llvm/llvm-project/blob/2e8ef93439a4a430fe5f96b9d999ce96405345f4/llvm/lib/Transforms/IPO/Attributor.cpp#L2141).
If you saw a problem, we need to address it generally.

10262

I doubt you need a manifest. Do you see the problems you are trying to avoid above?