[LLVM][OHOS] Use emulated TLS for OHOS platform

[kpdev42]

Summary

Both Linux and LiteOS for all OpenHarmony targets use emulated TLS

~~~

Huawei RRI, OS Lab

[DavidSpickett]

Both Linux and LiteOS for all OpenHarmony targets use emulated TLS

What does the LiteOS triple look like, should it be tested too?

[kpdev42]

The only supported arch for liteos is arm32

[DavidSpickett]

LGTM.

[DavidSpickett]

Though one last thing, should MIPS be mentioned here? https://reviews.llvm.org/D145227 adds targets for MIPS as well, do you not use emulated TLS there?

[jrtc27]

llvm/test/CodeGen/RISCV/emutls.ll

1

NACK for this test, just add your RUN lines to the one in the patch that adds emutls support to RISC-V.

llvm/test/CodeGen/RISCV/emutls_generic.ll

1 ↗

(On Diff #504635)

NACK to this too, duplicates

[kpdev42]

llvm/test/CodeGen/RISCV/emutls.ll

1

Excuse me, do you mean that it is better to prepare a separate patch for RISC-V, right?

[jrtc27]

llvm/test/CodeGen/RISCV/emutls.ll

1

D143708 adds emulated TLS support (which I assume is what you're using, since this patch doesn't modify the backend to support it) and includes a test for that. You are not adding emulated TLS support here, you're just changing a default, so you shouldn't be writing your own (worse) test for emulated TLS code generation, you should just be adding RUN lines to the test in the patch you're basing this on.

[kpdev42]

Updated after D143708 landed

[kpdev42]

@jrtc27 Patch was updated, please take a look

[DavidSpickett]

Though one last thing, should MIPS be mentioned here? https://reviews.llvm.org/D145227 adds targets for MIPS as well, do you not use emulated TLS there?

Is still outstanding, otherwise no objections.

[jrtc27]

One remaining nit as far as I can tell

llvm/test/CodeGen/ARM/emutls.ll

5

Leave this line alone

[kpdev42]

Address review comments

[MaskRay]

This patch adds too many RUN lines. I don't think enumerating every combination for your target triple makes good use of the number of RUN lines. Every RUN line adds a small overhead for all users.
I think adding a line to llvm/test/CodeGen/X86/emutls-pic.ll testing that emulated TLS is used by default is sufficient.

[kpdev42]

Address review comment

[kpdev42]

@jrtc27 Please take a look

llvm/include/llvm/TargetParser/Triple.h

public:
   /// Tests whether the target supports comdat
   bool supportsCOMDAT() const {
     return !(isOSBinFormatMachO() || isOSBinFormatXCOFF() ||
              isOSBinFormatDXContainer());
   }
 
   /// Tests whether the target uses emulated TLS as default.
   bool hasDefaultEmulatedTLS() const {
-    return isAndroid() || isOSOpenBSD() || isWindowsCygwinEnvironment();
+    return isAndroid() || isOSOpenBSD() || isWindowsCygwinEnvironment() ||
+           isOHOSFamily();
   }
 
   /// Tests whether the target uses -data-sections as default.
   bool hasDefaultDataSections() const {
     return isOSBinFormatXCOFF() || isWasm();
   }
 
   /// Tests if the environment supports dllimport/export annotations.

llvm/test/CodeGen/AArch64/emutls_generic.ll

 ; RUN: llc < %s -emulated-tls -mtriple=aarch64-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=ARM_64 %s
 ; RUN: llc < %s -emulated-tls -mtriple=aarch64-linux-android -relocation-model=pic -O3 \
 ; RUN:     | FileCheck -check-prefix=ARM_64 %s
 ; RUN: llc < %s -emulated-tls -mtriple=aarch64-linux-android -O3 \
 ; RUN:     | FileCheck -check-prefix=ARM_64 %s
 ; RUN: llc < %s -emulated-tls -mtriple=aarch64-windows-gnu -O3 \
 ; RUN:     | FileCheck -check-prefix=ARM_64 %s
 ; RUN: llc < %s -emulated-tls -mtriple=aarch64-apple-darwin -O3 \
 ; RUN:     | FileCheck -check-prefix=DARWIN %s
+; RUN: llc < %s -emulated-tls -mtriple=aarch64-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=ARM_64 %s
+; RUN: llc < %s -emulated-tls -mtriple=aarch64-linux-ohos -relocation-model=pic -O3 \
+; RUN:     | FileCheck -check-prefix=ARM_64 %s
+; RUN: llc < %s -emulated-tls -mtriple=aarch64-linux-ohos -O3 \
+; RUN:     | FileCheck -check-prefix=ARM_64 %s
 
 ; RUN: llc < %s -mtriple=aarch64-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=ARM_64 %s
 ; RUN: llc < %s -mtriple=aarch64-linux-android -relocation-model=pic -O3 \
 ; RUN:     | FileCheck -check-prefix=ARM_64 %s
 ; RUN: llc < %s -mtriple=aarch64-linux-android -O3 \
 ; RUN:     | FileCheck -check-prefix=ARM_64 %s
 ; aarch64-windows-gnu needs explicit -emulated-tls
 ; RUN: llc < %s -mtriple=aarch64-apple-darwin -O3 \
 ; RUN:     | FileCheck -check-prefix=NoEMU %s
+; RUN: llc < %s -mtriple=aarch64-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=ARM_64 %s
+; RUN: llc < %s -mtriple=aarch64-linux-ohos -relocation-model=pic -O3 \
+; RUN:     | FileCheck -check-prefix=ARM_64 %s
+; RUN: llc < %s -mtriple=aarch64-linux-ohos -O3 \
+; RUN:     | FileCheck -check-prefix=ARM_64 %s
 
 ; NoEMU-NOT: __emutls
 
 ; Make sure that TLS symbols are emitted in expected order.
 
 @external_x = external thread_local global i32, align 8
 @external_y = thread_local global i8 7, align 2
 @internal_y = internal thread_local global i64 9, align 16

llvm/test/CodeGen/ARM/emutls.ll

 ; RUN: llc -emulated-tls -mtriple=arm-linux-android \
 ; RUN:     -relocation-model=pic < %s | FileCheck -check-prefix=ARM32 %s
 ; RUN: llc -mtriple=arm-linux-android \
 ; RUN:     -relocation-model=pic < %s | FileCheck -check-prefix=ARM32 %s
 
+; RUN: llc -emulated-tls -mtriple=arm-linux-ohos \
+; RUN:     -relocation-model=pic < %s | FileCheck -check-prefix=ARM32 %s
+; RUN: llc -mtriple=arm-linux-ohos \
+; RUN:     -relocation-model=pic < %s | FileCheck -check-prefix=ARM32 %s
+; RUN: llc -mtriple=arm-liteos-ohos \
+; RUN:     -relocation-model=pic < %s | FileCheck -check-prefix=ARM32 %s
+
 ; Copied from X86/emutls.ll
 
 ; Use my_emutls_get_address like __emutls_get_address.
 @my_emutls_v_xyz = external global ptr, align 4
 declare ptr @my_emutls_get_address(ptr)
 
 define i32 @my_get_xyz() {
 ; ARM32-LABEL: my_get_xyz:

llvm/test/CodeGen/RISCV/emutls.ll

 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc -mtriple=riscv32 -emulated-tls -relocation-model=pic < %s \
 ; RUN:     | FileCheck -check-prefix=RV32 %s
 ; RUN: llc -mtriple=riscv64 -emulated-tls -relocation-model=pic < %s \
 ; RUN:     | FileCheck -check-prefix=RV64 %s
+; RUN: llc -mtriple=riscv32-linux-ohos -relocation-model=pic < %s \
+; RUN:     | FileCheck -check-prefix=RV32 %s
+; RUN: llc -mtriple=riscv64-linux-ohos -relocation-model=pic < %s \
+; RUN:     | FileCheck -check-prefix=RV64 %s
 
 @external_x = external thread_local global i32, align 8
 @y = thread_local global i8 7, align 2
 @internal_z = internal thread_local global i64 9, align 16
 
 define ptr @get_external_x() nounwind {
 ; RV32-LABEL: get_external_x:
 ; RV32:       # %bb.0: # %entry

llvm/test/CodeGen/X86/emutls-pic.ll

 ; RUN: llc < %s -emulated-tls -mtriple=i386-linux-gnu -relocation-model=pic | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-gnu -relocation-model=pic | FileCheck -check-prefix=X64 %s
 ; RUN: llc < %s -emulated-tls -mtriple=i386-linux-android -relocation-model=pic | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-android -relocation-model=pic | FileCheck -check-prefix=X64 %s
+; RUN: llc < %s -emulated-tls -mtriple=i386-linux-ohos -relocation-model=pic | FileCheck -check-prefix=X86 %s
+; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-ohos -relocation-model=pic | FileCheck -check-prefix=X64 %s
 
 ; RUN: llc < %s -mtriple=i386-linux-gnu -relocation-model=pic | FileCheck -check-prefix=NoEMU %s
 ; RUN: llc < %s -mtriple=x86_64-linux-gnu -relocation-model=pic | FileCheck -check-prefix=NoEMU %s
 ; RUN: llc < %s -mtriple=i386-linux-android -relocation-model=pic | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -mtriple=x86_64-linux-android -relocation-model=pic | FileCheck -check-prefix=X64 %s
+; RUN: llc < %s -mtriple=i386-linux-ohos -relocation-model=pic | FileCheck -check-prefix=X86 %s
+; RUN: llc < %s -mtriple=x86_64-linux-ohos -relocation-model=pic | FileCheck -check-prefix=X64 %s
 
 ; NoEMU-NOT: __emutls
 
 ; Use my_emutls_get_address like __emutls_get_address.
 @my_emutls_v_xyz = external global ptr, align 4
 declare ptr @my_emutls_get_address(ptr)
 
 define i32 @my_get_xyz() {

llvm/test/CodeGen/X86/emutls-pie.ll

 ; RUN: llc < %s -emulated-tls -mcpu=generic -mtriple=i386-linux-gnu -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -emulated-tls -mcpu=generic -mtriple=x86_64-linux-gnu -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=X64 %s
 ; RUN: llc < %s -emulated-tls -mcpu=generic -mtriple=i386-linux-android -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -emulated-tls -mcpu=generic -mtriple=x86_64-linux-android -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=X64 %s
+; RUN: llc < %s -emulated-tls -mcpu=generic -mtriple=i386-linux-ohos -relocation-model=pic \
+; RUN:   | FileCheck -check-prefix=X86 %s
+; RUN: llc < %s -emulated-tls -mcpu=generic -mtriple=x86_64-linux-ohos -relocation-model=pic \
+; RUN:   | FileCheck -check-prefix=X64 %s
 
 ; RUN: llc < %s -mcpu=generic -mtriple=i386-linux-gnu -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=NoEMU %s
 ; RUN: llc < %s -mcpu=generic -mtriple=x86_64-linux-gnu -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=NoEMU %s
 ; RUN: llc < %s -mcpu=generic -mtriple=i386-linux-android -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -mcpu=generic -mtriple=x86_64-linux-android -relocation-model=pic \
 ; RUN:   | FileCheck -check-prefix=X64 %s
+; RUN: llc < %s -mcpu=generic -mtriple=i386-linux-ohos -relocation-model=pic \
+; RUN:   | FileCheck -check-prefix=X86 %s
+; RUN: llc < %s -mcpu=generic -mtriple=x86_64-linux-ohos -relocation-model=pic \
+; RUN:   | FileCheck -check-prefix=X64 %s
 
 ; NoEMU-NOT: __emutls
 
 ; Use my_emutls_get_address like __emutls_get_address.
 @my_emutls_v_xyz = external global ptr, align 4
 declare ptr @my_emutls_get_address(ptr)
 
 define dso_local i32 @my_get_xyz() {

llvm/test/CodeGen/X86/emutls.ll

 ; RUN: llc < %s -emulated-tls -mtriple=i386-linux-gnu | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-gnu | FileCheck -check-prefix=X64 %s
 ; RUN: llc < %s -emulated-tls -mtriple=i386-linux-android | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-android | FileCheck -check-prefix=X64 %s
+; RUN: llc < %s -emulated-tls -mtriple=i386-linux-ohos | FileCheck -check-prefix=X86 %s
+; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-ohos | FileCheck -check-prefix=X64 %s
 
 ; RUN: llc < %s -mtriple=i386-linux-gnu | FileCheck -check-prefix=NoEMU %s
 ; RUN: llc < %s -mtriple=x86_64-linux-gnu | FileCheck -check-prefix=NoEMU %s
 ; RUN: llc < %s -mtriple=i386-linux-android | FileCheck -check-prefix=X86 %s
 ; RUN: llc < %s -mtriple=x86_64-linux-android | FileCheck -check-prefix=X64 %s
+; RUN: llc < %s -mtriple=i386-linux-ohos | FileCheck -check-prefix=X86 %s
+; RUN: llc < %s -mtriple=x86_64-linux-ohos | FileCheck -check-prefix=X64 %s
 
 ; Copied from tls.ll; emulated TLS model is not implemented
 ; for *-pc-win32 and *-pc-windows targets yet.
 
 ; NoEMU-NOT: __emutls
 
 ; Use my_emutls_get_address like __emutls_get_address.
 @my_emutls_v_xyz = external global ptr, align 4

llvm/test/CodeGen/X86/emutls_generic.ll

 ; RUN: llc < %s -emulated-tls -mtriple=i686-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=X86_32 %s
 ; RUN: llc < %s -emulated-tls -mtriple=i686-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=X86_32 %s
 ; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=X86_64 %s
 ; RUN: llc < %s -emulated-tls -mtriple=i386-linux-gnu -relocation-model=pic \
 ; RUN:     | FileCheck %s
+; RUN: llc < %s -emulated-tls -mtriple=i686-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=X86_32 %s
+; RUN: llc < %s -emulated-tls -mtriple=i686-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=X86_32 %s
+; RUN: llc < %s -emulated-tls -mtriple=x86_64-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=X86_64 %s
 
 ; RUN: llc < %s -mtriple=i686-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=X86_32 %s
 ; RUN: llc < %s -mtriple=i686-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=X86_32 %s
 ; RUN: llc < %s -mtriple=x86_64-linux-android -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=X86_64 %s
 ; RUN: llc < %s -mtriple=i386-linux-gnu -relocation-model=pic \
 ; RUN:     | FileCheck -check-prefix=NoEMU %s
+; RUN: llc < %s -mtriple=i686-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=X86_32 %s
+; RUN: llc < %s -mtriple=i686-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=X86_32 %s
+; RUN: llc < %s -mtriple=x86_64-linux-ohos -relocation-model=pic \
+; RUN:     | FileCheck -check-prefix=X86_64 %s
 
 ; NoEMU-NOT: __emutls
 
 ; Make sure that TLS symbols are emitted in expected order.
 
 @external_x = external thread_local global i32, align 8
 @external_y = thread_local global i8 7, align 2
 @internal_y = internal thread_local global i64 9, align 16