Including headers used to fire an assertion; now they report a
diagnostic similarly to unstructured diagnostics.
Depends on D146654.
Paths
| Differential D145201
[clang] fixes header processing for `-fdiagnostics-format=sarif` AcceptedPublic Authored by cjdb on Mar 2 2023, 3:16 PM.
Details
Summary Including headers used to fire an assertion; now they report a Depends on D146654.
Diff Detail
Event TimelineComment Actions It looks like there's a valid precommit CI failure that needs to be addressed: ******************** Failed Tests (1): Clang :: Frontend/sarif-diagnostics.cpp
Comment Actions This comment has been deleted.
cjdb added a child revision: D145284: WIP [clang] adds capabilities for SARIF to be written to file.Mar 3 2023, 4:14 PM
Comment Actions (Note, precommit CI on Windows still shows a valid failure.)
cjdb added a child revision: D146654: [clang] replaces numeric SARIF ids with heirarchical names.Mar 22 2023, 11:45 AM cjdb removed a parent revision: D145178: [clang][NFC] reformats the SARIF diagnostic test so it's human readable. Comment Actions
Oh, if this is just stacked patches confusing our precommit CI, then it's okay. I hadn't realized this was a stacked patch. Comment Actions LGTM aside from a tiny variable naming nit I missed before.
This revision is now accepted and ready to land.Mar 23 2023, 7:21 AM Comment Actions
No, I introduced a new patch and it was weirdly failing everything, so I decided to see if it could be merged before this one.
Revision Contents
Diff 502190 clang/include/clang/Frontend/SARIFDiagnostic.h
clang/lib/Basic/Sarif.cpp
clang/lib/Frontend/SARIFDiagnostic.cpp
clang/test/Frontend/sarif-diagnostics.cpp
|
I'm wondering if I should instead copy CurrentArtifacts to a vector and sort prior to insertion, rather than in post.