User Details
- User Since
- Aug 2 2019, 2:52 PM (158 w, 4 d)
Wed, Aug 3
Tue, Jul 19
Mon, Jul 18
Thanks for adding the flag!
Jul 7 2022
Thanks Abraham!
Jun 27 2022
Thanks for adding a check! Please check my comments.
Feb 11 2022
Feb 10 2022
Feb 9 2022
Correct, I meant Chrome OS tests. Chrome OS uses Gentoo sandboxing for its unit tests.
This change breaks tests with sanitizers running in a sandbox.
If /usr/local/tmp/asan is in the allow-list for writing, the sandbox will kill the test when it tries to create /usr.
Jan 17 2020
We are hitting the warning in template code with bool and loop like this: "for (const auto& element : value)" where element is bool from template. But not always.
When it is bool the warning triggers:
error: loop variable 'element' is always a copy because the range of type 'const std::vector<bool, allocator<bool> >' does not return a reference [-Werror,-Wrange-loop-analysis]
Sep 12 2019
Combined two if into one.
Sep 11 2019
Ping @aaron.ballman , please verify the change.
Aug 28 2019
Hi Aaron,
Aug 19 2019
Removed check for libraries.
Manoj, please check updated diff.
Changed Wpoison-system-directories warning to be disabled by default.
Aug 14 2019
Fixed clang-format.
Updated the code (removed Diag propagation).
Added test cases.
Aug 8 2019
Taking ownership of the change as Yunlian is no longer working on this CL.