User Details
- User Since
- Aug 2 2019, 2:52 PM (217 w, 1 d)
Aug 15 2023
May 30 2023
As long as having In file included from on each error without notes from one include file is fine, I don't see any problem with this. LGTM.
But let's check what others think about it.
May 25 2023
Thanks @SlaterLatiao!
May 24 2023
Mar 22 2023
Jan 23 2023
Jan 10 2023
Thanks @v1nh1shungry for the fix!
The change and test cases look good to me.
Dec 2 2022
Replaced deprecated [[@LINE-1]]
Format changes.
Oct 25 2022
@Eugene.Zelenko , could you please stamp the patch if you don't have any other concerns?
Sep 29 2022
@LegalizeAdulthood, @njames93, friendly ping.
Sep 21 2022
@LegalizeAdulthood, @njames93, is there anything else we should address in this change?
Sep 16 2022
Any updates from the reviewers?
Aug 26 2022
Aug 25 2022
Aug 24 2022
Aug 22 2022
Aug 19 2022
Thanks Abraham!
Aug 3 2022
Jul 19 2022
Jul 18 2022
Thanks for adding the flag!
Jul 7 2022
Thanks Abraham!
Jun 27 2022
Thanks for adding a check! Please check my comments.
Feb 11 2022
Feb 10 2022
Feb 9 2022
Correct, I meant Chrome OS tests. Chrome OS uses Gentoo sandboxing for its unit tests.
This change breaks tests with sanitizers running in a sandbox.
If /usr/local/tmp/asan is in the allow-list for writing, the sandbox will kill the test when it tries to create /usr.
Jan 17 2020
We are hitting the warning in template code with bool and loop like this: "for (const auto& element : value)" where element is bool from template. But not always.
When it is bool the warning triggers:
error: loop variable 'element' is always a copy because the range of type 'const std::vector<bool, allocator<bool> >' does not return a reference [-Werror,-Wrange-loop-analysis]
Sep 12 2019
Combined two if into one.
Sep 11 2019
Ping @aaron.ballman , please verify the change.
Aug 28 2019
Hi Aaron,
Aug 19 2019
Removed check for libraries.
Manoj, please check updated diff.
Changed Wpoison-system-directories warning to be disabled by default.
Aug 14 2019
Fixed clang-format.
Updated the code (removed Diag propagation).
Added test cases.
Aug 8 2019
Taking ownership of the change as Yunlian is no longer working on this CL.