Including headers used to fire an assertion; now they report a
diagnostic similarly to unstructured diagnostics.
Depends on D146654.
Differential D145201
[clang] fixes header processing for `-fdiagnostics-format=sarif` cjdb on Mar 2 2023, 3:16 PM. Authored by
Details
Including headers used to fire an assertion; now they report a Depends on D146654.
Diff Detail
Event TimelineComment Actions It looks like there's a valid precommit CI failure that needs to be addressed: ******************** Failed Tests (1): Clang :: Frontend/sarif-diagnostics.cpp
Comment Actions This comment has been deleted.
Comment Actions (Note, precommit CI on Windows still shows a valid failure.)
Comment Actions Oh, if this is just stacked patches confusing our precommit CI, then it's okay. I hadn't realized this was a stacked patch. Comment Actions LGTM aside from a tiny variable naming nit I missed before.
Comment Actions No, I introduced a new patch and it was weirdly failing everything, so I decided to see if it could be merged before this one. |