Page MenuHomePhabricator

[clang-tidy] improve readability-identifier-naming hungarian options test
ClosedPublic

Authored by amurzeau on Feb 21 2023, 11:19 AM.

Details

Summary

Adjust identifier-naming-hungarian-notation-cfgfile test with
changes for all configs in .clang-tidy to ensure they are really taken
into account.

This is done this way:

  • Set all HungarianNotation.* options to cust prefix + their default value.
  • Set TreatStructAsClass to true as it defaults to false.
  • Because of the TreatStructAsClass change, add a test to check that structs are really checked the same way as classes (see struct StructCase).

Also, TreatStructAsClass was wrongly named in the test's .clang-tidy file
and was fixed (it is in General, not in Options).

Depends on D144431

Diff Detail

Event Timeline

amurzeau created this revision.Feb 21 2023, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 11:19 AM
Herald added a subscriber: xazax.hun. · View Herald Transcript
amurzeau requested review of this revision.Feb 21 2023, 11:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 11:19 AM
This revision is now accepted and ready to land.Feb 21 2023, 10:58 PM

@amurzeau I'm having some trouble downloading the patch, would you mind trying out a rebase on top of latest master? Otherwise I'll try downloading the raw diff.

amurzeau updated this revision to Diff 500256.Fri, Feb 24, 10:46 AM

Rebase on main

This revision was landed with ongoing or failed builds.Fri, Feb 24, 11:18 AM
This revision was automatically updated to reflect the committed changes.