This is an archive of the discontinued LLVM Phabricator instance.

Differential D143916

[runtimes] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default to ON for OS390
ClosedPublic

Authored by fanbo-meng on Feb 13 2023, 7:31 AM.

Details

Reviewers
NancyWang2222
abhina.sreeskantharajan
SeanP
zibi
• neumannh
Kai
Commits
rG17b097b8df69: [runtimes] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default to ON for OS390

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy
60,070 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp

Event Timeline

fanbo-meng created this revision.Feb 13 2023, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2023, 7:32 AM
fanbo-meng requested review of this revision.Feb 13 2023, 7:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2023, 7:32 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fanbo-meng added reviewers: NancyWang2222, abhina.sreeskantharajan, SeanP, zibi, • neumannh, Kai.Feb 13 2023, 8:04 AM
zibi accepted this revision.Feb 13 2023, 8:07 AM

LGTM

This revision is now accepted and ready to land.Feb 13 2023, 8:07 AM
abhina.sreeskantharajan accepted this revision.Feb 13 2023, 8:10 AM

LGTM

Harbormaster completed remote builds in B213427: Diff 496980.Feb 13 2023, 8:23 AM
This revision was landed with ongoing or failed builds.Feb 13 2023, 1:37 PM
Closed by commit rG17b097b8df69: [runtimes] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default to ON for OS390 (authored by fanbo-meng). · Explain Why
This revision was automatically updated to reflect the committed changes.
fanbo-meng added a commit: rG17b097b8df69: [runtimes] Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default to ON for OS390.

Revision Contents

PathSize
llvm/
2 lines

Diff 496980

llvm/CMakeLists.txt

Show First 20 Lines • Show All 821 Lines • ▼ Show 20 Lines
if(CMAKE_HOST_APPLE AND APPLE) if(CMAKE_HOST_APPLE AND APPLE)
include(UseLibtool) include(UseLibtool)
endif() endif()
# Override the default target with an environment variable named by LLVM_TARGET_TRIPLE_ENV. # Override the default target with an environment variable named by LLVM_TARGET_TRIPLE_ENV.
set(LLVM_TARGET_TRIPLE_ENV CACHE STRING "The name of environment variable to override default target. Disabled by blank.") set(LLVM_TARGET_TRIPLE_ENV CACHE STRING "The name of environment variable to override default target. Disabled by blank.")
mark_as_advanced(LLVM_TARGET_TRIPLE_ENV) mark_as_advanced(LLVM_TARGET_TRIPLE_ENV)
if(CMAKE_SYSTEM_NAME MATCHES "BSD|Linux") if(CMAKE_SYSTEM_NAME MATCHES "BSD|Linux|OS390")
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON) set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
else() else()
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default OFF) set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default OFF)
endif() endif()
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default} CACHE BOOL set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default} CACHE BOOL
"Enable per-target runtimes directory") "Enable per-target runtimes directory")
set(LLVM_PROFDATA_FILE "" CACHE FILEPATH set(LLVM_PROFDATA_FILE "" CACHE FILEPATH
▲ Show 20 Lines • Show All 518 Lines • Show Last 20 Lines