This is an archive of the discontinued LLVM Phabricator instance.

Differential D143360

[RISCV] Clean up stack-protector-target test
ClosedPublic

Authored by mcgrathr on Feb 5 2023, 7:08 PM.

Details

Reviewers
jrtc27
Commits
rG2406f3bea545: [RISCV] Clean up stack-protector-target test
Summary

Add some missed polish from https://reviews.llvm.org/D143355.

Diff Detail

Unit TestsFailed

TimeTest
60,080 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,050 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test
60,040 msx64 debian > libFuzzer.libFuzzer::value-profile-load.test

Event Timeline

mcgrathr created this revision.Feb 5 2023, 7:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2023, 7:08 PM
Herald added subscribers: luke, VincentWu, vkmr and 26 others. · View Herald Transcript
mcgrathr requested review of this revision.Feb 5 2023, 7:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2023, 7:08 PM
Herald added subscribers: llvm-commits, • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
jrtc27 accepted this revision.Feb 5 2023, 7:09 PM

Thanks

This revision is now accepted and ready to land.Feb 5 2023, 7:09 PM
mcgrathr mentioned this in D143353: [RISCV] Use OS-specific stack-guard ABI for Fuchsia.Feb 5 2023, 7:10 PM
Harbormaster completed remote builds in B211987: Diff 494982.Feb 5 2023, 7:54 PM
This revision was landed with ongoing or failed builds.Feb 6 2023, 4:43 PM
Closed by commit rG2406f3bea545: [RISCV] Clean up stack-protector-target test (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rG2406f3bea545: [RISCV] Clean up stack-protector-target test.

Revision Contents

PathSize
llvm/
test/
CodeGen/
RISCV/
6 lines

Diff 494982

llvm/test/CodeGen/RISCV/stack-protector-target.ll

; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
;; Test target-specific stack cookie location. ;; Test target-specific stack cookie location.
; ;
; RUN: llc -mtriple=riscv64-fuchsia < %s | FileCheck --check-prefix=FUCHSIA-RISCV64 %s ; RUN: llc -mtriple=riscv64-fuchsia < %s | FileCheck --check-prefix=FUCHSIA-RISCV64 %s
define void @func() sspreq { define void @func() sspreq nounwind {
; FUCHSIA-RISCV64-LABEL: func: ; FUCHSIA-RISCV64-LABEL: func:
; FUCHSIA-RISCV64: # %bb.0: ; FUCHSIA-RISCV64: # %bb.0:
; FUCHSIA-RISCV64-NEXT: addi sp, sp, -32 ; FUCHSIA-RISCV64-NEXT: addi sp, sp, -32
; FUCHSIA-RISCV64-NEXT: .cfi_def_cfa_offset 32
; FUCHSIA-RISCV64-NEXT: sd ra, 24(sp) # 8-byte Folded Spill ; FUCHSIA-RISCV64-NEXT: sd ra, 24(sp) # 8-byte Folded Spill
; FUCHSIA-RISCV64-NEXT: .cfi_offset ra, -8
; FUCHSIA-RISCV64-NEXT: ld a0, -16(tp) ; FUCHSIA-RISCV64-NEXT: ld a0, -16(tp)
; FUCHSIA-RISCV64-NEXT: sd a0, 16(sp) ; FUCHSIA-RISCV64-NEXT: sd a0, 16(sp)
; FUCHSIA-RISCV64-NEXT: addi a0, sp, 12 ; FUCHSIA-RISCV64-NEXT: addi a0, sp, 12
; FUCHSIA-RISCV64-NEXT: call capture@plt ; FUCHSIA-RISCV64-NEXT: call capture@plt
; FUCHSIA-RISCV64-NEXT: ld a0, -16(tp) ; FUCHSIA-RISCV64-NEXT: ld a0, -16(tp)
; FUCHSIA-RISCV64-NEXT: ld a1, 16(sp) ; FUCHSIA-RISCV64-NEXT: ld a1, 16(sp)
; FUCHSIA-RISCV64-NEXT: bne a0, a1, .LBB0_2 ; FUCHSIA-RISCV64-NEXT: bne a0, a1, .LBB0_2
; FUCHSIA-RISCV64-NEXT: # %bb.1: # %SP_return ; FUCHSIA-RISCV64-NEXT: # %bb.1: # %SP_return
; FUCHSIA-RISCV64-NEXT: ld ra, 24(sp) # 8-byte Folded Reload ; FUCHSIA-RISCV64-NEXT: ld ra, 24(sp) # 8-byte Folded Reload
; FUCHSIA-RISCV64-NEXT: addi sp, sp, 32 ; FUCHSIA-RISCV64-NEXT: addi sp, sp, 32
; FUCHSIA-RISCV64-NEXT: ret ; FUCHSIA-RISCV64-NEXT: ret
; FUCHSIA-RISCV64-NEXT: .LBB0_2: # %CallStackCheckFailBlk ; FUCHSIA-RISCV64-NEXT: .LBB0_2: # %CallStackCheckFailBlk
; FUCHSIA-RISCV64-NEXT: call __stack_chk_fail@plt ; FUCHSIA-RISCV64-NEXT: call __stack_chk_fail@plt
%1 = alloca i32, align 4 %1 = alloca i32, align 4
call void @capture(ptr nonnull %1) call void @capture(ptr %1)
ret void ret void
} }
declare void @capture(ptr) declare void @capture(ptr)